MFH: Fixed bug #33523 (Memory leak in xmlrpc_encode_request()).

diff --git a/NEWS b/NEWS
index 36321ebc3959c965712139907bec5625262be072..5dce0d5987c613f056b6d2dbd3fd49000a0bf403 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -11,6 +11,7 @@ PHP 4                                                                      NEWS
 - Fixed bug #35062 (socket_read() produces warnings on non blocking sockets).
   (Nuno, Ilia)
 - Fixed bug #34359 (Possible crash inside fopen http wrapper). (Ilia,Nuno,Sara)
+- Fixed bug #33523 (Memory leak in xmlrpc_encode_request()). (Ilia)
 - Fixed bug #33153 (crash in mssql_next result). (Frank)
 - Fixed bug #32009 (crash when mssql_bind() is called more than once). (Frank)
 - Fixed bug #33963 (mssql_bind() fails on input parameters). (Frank)

diff --git a/ext/xmlrpc/xmlrpc-epi-php.c b/ext/xmlrpc/xmlrpc-epi-php.c
index 6a83899659ffc52f05308cd31ca9137f574ec9ac..8e84d2567789c5d36cb71a473253cccf1eb0c743 100644 (file)
--- a/ext/xmlrpc/xmlrpc-epi-php.c
+++ b/ext/xmlrpc/xmlrpc-epi-php.c
@@ -684,8 +684,13 @@ PHP_FUNCTION(xmlrpc_encode_request)
             free(outBuf);
          }
          XMLRPC_RequestFree(xRequest, 1);
+
+       
       }
    }
+       if (out.xmlrpc_out.xml_elem_opts.encoding != ENCODING_DEFAULT) {
+               efree(out.xmlrpc_out.xml_elem_opts.encoding);
+       }
 }
 /* }}} */