Avoid double close of file handle in syslogger on win32

This causes an exception when running under a debugger or in particular
when running on a debug version of Windows.

Patch from MauMau

diff --git a/src/backend/postmaster/syslogger.c b/src/backend/postmaster/syslogger.c
index 067f7efc646093d6669d9a647c796a78b0b08155..20ed92d550b422ba613a4f86018f6f5b299c8625 100644 (file)
--- a/src/backend/postmaster/syslogger.c
+++ b/src/backend/postmaster/syslogger.c
@@ -593,8 +593,11 @@ SysLogger_Start(void)
                                                         errmsg("could not redirect stderr: %m")));
                                close(fd);
                                _setmode(_fileno(stderr), _O_BINARY);
-                               /* Now we are done with the write end of the pipe. */
-                               CloseHandle(syslogPipe[1]);
+                               /*
+                                * Now we are done with the write end of the pipe.
+                                * CloseHandle() must not be called because the preceding
+                                * close() closes the underlying handle.
+                               */
                                syslogPipe[1] = 0;
 #endif
                                redirection_done = true;