Fix Coverity warnings.

 - Check the correct variable (str_obj, not str) for NULL
 - sep_len was already verified it wasn't 0

diff --git a/Objects/stringlib/partition.h b/Objects/stringlib/partition.h
index 8cc7abeaaf62ac4f5c632f30fb4d1a5554aac659..11a12c6f46dfa04bcbaa9f332177481b24612a47 100644 (file)
--- a/Objects/stringlib/partition.h
+++ b/Objects/stringlib/partition.h
@@ -58,7 +58,7 @@ stringlib_rpartition(
     )
 {
     PyObject* out;
-    Py_ssize_t pos;
+    Py_ssize_t pos, j;
 
     if (sep_len == 0) {
         PyErr_SetString(PyExc_ValueError, "empty separator");
@@ -70,17 +70,12 @@ stringlib_rpartition(
        return NULL;
 
     /* XXX - create reversefastsearch helper! */
-    if (sep_len == 0)
-       pos = str_len;
-    else {
-       Py_ssize_t j;
         pos = -1;
        for (j = str_len - sep_len; j >= 0; --j)
             if (STRINGLIB_CMP(str+j, sep, sep_len) == 0) {
                 pos = j;
                 break;
             }
-    }
 
     if (pos < 0) {
        Py_INCREF(str_obj);

diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
index d5935e31df86bac6c878e41064394e32b7fa3b6d..783eb8f2a8a5cc9db973dea9cd586c6505fd9552 100644 (file)
--- a/Objects/unicodeobject.c
+++ b/Objects/unicodeobject.c
@@ -3955,7 +3955,7 @@ Py_ssize_t PyUnicode_Find(PyObject *str,
     PyUnicodeObject* sub_obj;
 
     str_obj = (PyUnicodeObject*) PyUnicode_FromObject(str);
-    if (!str)
+    if (!str_obj)
        return -2;
     sub_obj = (PyUnicodeObject*) PyUnicode_FromObject(substr);
     if (!sub_obj) {