]> granicus.if.org Git - nethack/commitdiff
skipinvert handling in tty menus
authorPatR <rankin@nethack.org>
Wed, 4 May 2022 21:19:16 +0000 (14:19 -0700)
committerPatR <rankin@nethack.org>
Wed, 4 May 2022 21:19:16 +0000 (14:19 -0700)
Select all and unselect all were passing the wrong third argument to
menuitem_invert_test().  Select page and unselect page had it right.

win/tty/wintty.c

index 113cf883fac88223fc951079de5403b74a08de0e..5ddfabdd4e63e17c301d8741220dd70e42d6ed5c 100644 (file)
@@ -2199,7 +2199,8 @@ process_menu_window(winid window, struct WinDesc *cw)
                 for (curr = cw->mlist; curr; curr = curr->next) {
                     if (!curr->identifier.a_void /* not selectable */
                         || curr->selected /* already selected */
-                        || !menuitem_invert_test(1, curr->itemflags, TRUE))
+                        /* FALSE: not currently selected */
+                        || !menuitem_invert_test(1, curr->itemflags, FALSE))
                         continue;
                     curr->selected = TRUE;
                 }
@@ -2215,7 +2216,8 @@ process_menu_window(winid window, struct WinDesc *cw)
             for (curr = cw->mlist; curr; curr = curr->next) {
                 if (!curr->identifier.a_void /* not selectable */
                     || !curr->selected /* already de-selected */
-                    || !menuitem_invert_test(2, curr->itemflags, FALSE))
+                    /* TRUE: currently selected */
+                    || !menuitem_invert_test(2, curr->itemflags, TRUE))
                     continue;
                 curr->selected = FALSE;
                 curr->count = -1;