Remove a needless branch in evbuffer_drain()

Found by Gilad Benjamini; see June 2011 thread "Dead or wrong code".

diff --git a/buffer.c b/buffer.c
index 98de504c2b6fe2576362b62986b2ad99e0b2770d..84d3aea854b53e37e5e0e78ab31a8a845a2ee884 100644 (file)
--- a/buffer.c
+++ b/buffer.c
@@ -934,10 +934,8 @@ evbuffer_drain(struct evbuffer *buf, size_t len)
                }
 
                buf->first = chain;
-               if (chain) {
-                       chain->misalign += remaining;
-                       chain->off -= remaining;
-               }
+               chain->misalign += remaining;
+               chain->off -= remaining;
        }
 
        buf->n_del_for_cb += len;