]> granicus.if.org Git - python/commitdiff
bpo-31448, test_poplib: Fix ResourceWarning (#3542)
authorVictor Stinner <victor.stinner@gmail.com>
Wed, 13 Sep 2017 12:53:10 +0000 (05:53 -0700)
committerGitHub <noreply@github.com>
Wed, 13 Sep 2017 12:53:10 +0000 (05:53 -0700)
Call POP3.close(), don't close close directly the sock attribute.

Lib/test/test_poplib.py

index d7a26bc14c9197764ce3b7dcfacde2051d088cdd..721ea252011964288438b87355c99b8d80c3770a 100644 (file)
@@ -488,7 +488,7 @@ class TestTimeouts(TestCase):
         finally:
             socket.setdefaulttimeout(None)
         self.assertEqual(pop.sock.gettimeout(), 30)
-        pop.sock.close()
+        pop.close()
 
     def testTimeoutNone(self):
         self.assertIsNone(socket.getdefaulttimeout())
@@ -498,12 +498,12 @@ class TestTimeouts(TestCase):
         finally:
             socket.setdefaulttimeout(None)
         self.assertIsNone(pop.sock.gettimeout())
-        pop.sock.close()
+        pop.close()
 
     def testTimeoutValue(self):
         pop = poplib.POP3(HOST, self.port, timeout=30)
         self.assertEqual(pop.sock.gettimeout(), 30)
-        pop.sock.close()
+        pop.close()
 
 
 def test_main():