Turn off aspect attribute in dot until it can be fixed

diff --git a/doc/info/attrs.html b/doc/info/attrs.html
index 2d10f29edf06b138752e4fd1e792bdc7bb6f3e69..df1aae7a29a018b467f8538798acc46db8491df4 100644 (file)
--- a/doc/info/attrs.html
+++ b/doc/info/attrs.html
@@ -574,7 +574,11 @@ This field indicates which graph component uses the attribute.
   See the <A HREF=#h:undir_note>limitation</A>.
 
 <DT><A NAME=d:aspect HREF=#a:aspect><STRONG>aspect</STRONG></A>
-<DD>  Target aspect ratio (width of the layout divided by the height)
+<DD>  <B>NOTE</B>: As of 2.35 and until further notice, 
+  dot will not support the <TT>aspect</TT>
+  attribute. There are some significant flaws in the implementation.
+  <P>
+  Target aspect ratio (width of the layout divided by the height)
   of the graph drawing. If unset, dot minimizes the total edge length.
   For certain graphs, like those with large fan-in or fan-out, this can
   lead to very wide layouts. Setting <TT>aspect</TT> will cause dot to try

diff --git a/doc/infosrc/attrs b/doc/infosrc/attrs
index f6a775e972884ce8be04a95fe6a401a0b3efa2b7..88a76cfc4ad7873eb85a181e87b44db3aeecfdb9 100644 (file)
--- a/doc/infosrc/attrs
+++ b/doc/infosrc/attrs
@@ -93,6 +93,10 @@ This will only appear if the <A HREF=#d:dir>dir</A> attribute
 is "back" or "both".
 See the <A HREF=#h:undir_note>limitation</A>.
 :aspect:G:aspectType; dot
+<B>NOTE</B>: As of 2.35 and until further notice, 
+dot will not support the <TT>aspect</TT>
+attribute. There are some significant flaws in the implementation.
+<P>
 Target aspect ratio (width of the layout divided by the height)
 of the graph drawing. If unset, dot minimizes the total edge length.
 For certain graphs, like those with large fan-in or fan-out, this can

diff --git a/lib/dotgen/aspect.c b/lib/dotgen/aspect.c
index c55533ea66a1557cabf5f4c244f7b1353be07396..7fe895d279df2c075f07dc5bf11e76aa42c3f6c9 100644 (file)
--- a/lib/dotgen/aspect.c
+++ b/lib/dotgen/aspect.c
@@ -1988,6 +1988,7 @@ setAspect (Agraph_t * g, aspect_t* adata)
        adata->badGraph = 0;
        return NULL;
     }
+    agerr(AGWARN, "The aspect attribute is currently disabled in dot - ignored\n");
     
     if (rv < MIN_AR) rv = MIN_AR;
     else if (rv > MAX_AR) rv = MAX_AR;