]> granicus.if.org Git - pdns/commitdiff
Fix counting of `rec_control help` elements and grep syntax
authorRemi Gacogne <remi.gacogne@powerdns.com>
Tue, 16 Aug 2016 15:35:40 +0000 (17:35 +0200)
committerRemi Gacogne <remi.gacogne@powerdns.com>
Thu, 25 Aug 2016 08:52:05 +0000 (10:52 +0200)
regression-tests.recursor/rec_control-manpage/command

index bbcaa9e7707b671341f24f2c9f3f50958e02927c..89a127f5a6822b5b19989f73c9f5b5ce61ea8d36 100755 (executable)
@@ -1,16 +1,16 @@
 #!/bin/sh
 elements="$($RECCONTROL --config-dir=./configs/recursor-service help | grep -v -e '^ ' | awk '{print $1}')"
 
-num_elems="$( echo $elements | wc -l)"
+num_elems="$( echo "$elements" | wc -l)"
 
 if [ $num_elems -lt 5 ]; then
-  echo "Not enough elements"
+  echo "Not enough elements ($num_elems)"
   exit 1
 fi
 
 missing_elements=""
 for element in $elements; do
-  grep -e -q "^$element" ../docs/manpages/rec_control.1.md || missing_elements="$element\n$missing_elements"
+  grep -q -e "^$element" ../docs/manpages/rec_control.1.md || missing_elements="$element\n$missing_elements"
 done
 
 if [ "x$missing_elements" != "x" ]; then