]> granicus.if.org Git - clang/commitdiff
Add a test case for the divide-by-zero fix in r137234
authorKaelyn Uhrain <rikka@google.com>
Wed, 10 Aug 2011 19:47:25 +0000 (19:47 +0000)
committerKaelyn Uhrain <rikka@google.com>
Wed, 10 Aug 2011 19:47:25 +0000 (19:47 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@137240 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaChecking.cpp
test/Sema/array-bounds-ptr-arith.c [new file with mode: 0644]

index d1fa196569315aba38c905ed4bb152a2a6b2ec2b..94e1c4f331e3649782338e66ad146b491c7b5a36 100644 (file)
@@ -3553,6 +3553,7 @@ void Sema::CheckArrayAccess(const Expr *BaseExpr, const Expr *IndexExpr,
       // Make sure we're comparing apples to apples when comparing index to size
       uint64_t ptrarith_typesize = Context.getTypeSize(EffectiveType);
       uint64_t array_typesize = Context.getTypeSize(BaseType);
+      // Handle ptrarith_typesize being zero, such as when casting to void*
       if (!ptrarith_typesize) ptrarith_typesize = 1;
       if (ptrarith_typesize != array_typesize) {
         // There's a cast to a different size type involved
diff --git a/test/Sema/array-bounds-ptr-arith.c b/test/Sema/array-bounds-ptr-arith.c
new file mode 100644 (file)
index 0000000..c0e0d0e
--- /dev/null
@@ -0,0 +1,14 @@
+// RUN: %clang_cc1 -verify -Warray-bounds-pointer-arithmetic %s
+
+// Test case from PR10615
+struct ext2_super_block{
+  unsigned char s_uuid[8]; // expected-note {{declared here}}
+};
+void* ext2_statfs (struct ext2_super_block *es,int a)
+{
+        return (void *)es->s_uuid + sizeof(int); // no-warning
+}
+void* broken (struct ext2_super_block *es,int a)
+{
+        return (void *)es->s_uuid + 80; // expected-warning {{refers past the end of the array}}
+}