Fix missing parentheses resulting in wrong order of dereference.

This could result in referencing uninitialized memory.

Michael Paquier, in response to a complaint from Andres Freund

diff --git a/src/backend/access/heap/tuptoaster.c b/src/backend/access/heap/tuptoaster.c
index 633717a446d2b37cb43af706f1eaeb5b50fcdf4b..97c9f238a7bba104a8a43838b1576ae8dafa5257 100644 (file)
--- a/src/backend/access/heap/tuptoaster.c
+++ b/src/backend/access/heap/tuptoaster.c
@@ -2156,7 +2156,7 @@ toast_open_indexes(Relation toastrel,
        /* Fetch the first valid index in list */
        for (i = 0; i < *num_indexes; i++)
        {
-               Relation toastidx = *toastidxs[i];
+               Relation toastidx = (*toastidxs)[i];
                if (toastidx->rd_index->indisvalid)
                {
                        res = i;