Build with -fno-common to catch definition problems

Fix some global variables not declared as extern

https://bugs.freedesktop.org/show_bug.cgi?id=66015

diff --git a/configure.ac b/configure.ac
index 5eb6c2c826576b9d3ee6b7f67e0bfc661a415208..b0bbbd50ae12c090b8c34112db884881d23b5890 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -378,7 +378,7 @@ if test "$GCC" = "yes"; then
                -Wmissing-prototypes -Wnested-externs -Wpointer-arith \
                -Wdeclaration-after-statement -Wformat=2 -Winit-self \
                -Waggregate-return -Wno-missing-format-attribute \
-               -fno-strict-aliasing"
+               -fno-strict-aliasing -fno-common"
 
        for option in -Wmissing-include-dirs -Wundef; do
                SAVE_CFLAGS="$CFLAGS"

diff --git a/p11-kit/virtual.h b/p11-kit/virtual.h
index f1fb67662c4346df2f74d7222a259d82a819923a..d29ea49d43ac7cf69f491a41d855b21fcdfa5f80 100644 (file)
--- a/p11-kit/virtual.h
+++ b/p11-kit/virtual.h
@@ -45,9 +45,9 @@ typedef struct {
        p11_destroyer lower_destroy;
 } p11_virtual;
 
-CK_X_FUNCTION_LIST      p11_virtual_base;
+extern CK_X_FUNCTION_LIST p11_virtual_base;
 
-CK_X_FUNCTION_LIST      p11_virtual_stack;
+extern CK_X_FUNCTION_LIST p11_virtual_stack;
 
 void                    p11_virtual_init       (p11_virtual *virt,
                                                 CK_X_FUNCTION_LIST *funcs,