]> granicus.if.org Git - php/commitdiff
this looks like a much better fix for refcounting/shutdown in lazy objects.
authorWez Furlong <wez@php.net>
Fri, 22 Jul 2005 04:33:56 +0000 (04:33 +0000)
committerWez Furlong <wez@php.net>
Fri, 22 Jul 2005 04:33:56 +0000 (04:33 +0000)
ext/pdo/pdo_stmt.c

index 240b370eed58276fec2e766fffab307705dfe74b..f8da1d121d469b704e99903e7f91e7ea332c02aa 100755 (executable)
@@ -222,7 +222,7 @@ static void get_lazy_object(pdo_stmt_t *stmt, zval *return_value TSRMLS_DC) /* {
                Z_TYPE(stmt->lazy_object_ref) = IS_OBJECT;
                Z_OBJ_HANDLE(stmt->lazy_object_ref) = zend_objects_store_put(stmt, (zend_objects_store_dtor_t)zend_objects_destroy_object, (zend_objects_free_object_storage_t)pdo_row_free_storage, NULL TSRMLS_CC);
                Z_OBJ_HT(stmt->lazy_object_ref) = &pdo_row_object_handlers;
-               stmt->refcount++;
+               /* stmt->refcount++; */
        }
        Z_TYPE_P(return_value) = IS_OBJECT;
        Z_OBJ_HANDLE_P(return_value) = Z_OBJ_HANDLE(stmt->lazy_object_ref);
@@ -2311,11 +2311,13 @@ zend_object_handlers pdo_row_object_handlers = {
 
 void pdo_row_free_storage(pdo_stmt_t *stmt TSRMLS_DC)
 {
+#if 0
        ZVAL_NULL(&stmt->lazy_object_ref);
        
        if (--stmt->refcount == 0) {
                free_statement(stmt TSRMLS_CC);
        }
+#endif
 }
 
 zend_object_value pdo_row_new(zend_class_entry *ce TSRMLS_DC)