]> granicus.if.org Git - python/commitdiff
use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896)
authorBenjamin Peterson <benjamin@python.org>
Wed, 12 Mar 2014 23:05:53 +0000 (18:05 -0500)
committerBenjamin Peterson <benjamin@python.org>
Wed, 12 Mar 2014 23:05:53 +0000 (18:05 -0500)
Lib/test/test_ssl.py

index 4d67fa1de4fcd92757b58b0e47a1636d75a62fa8..5c8df8bad86472551f9098ab13451319d9586520 100644 (file)
@@ -690,12 +690,15 @@ class NetworkedTests(unittest.TestCase):
 
     def test_get_server_certificate(self):
         with support.transient_internet("svn.python.org"):
-            pem = ssl.get_server_certificate(("svn.python.org", 443))
+            pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                             ssl.PROTOCOL_SSLv23)
             if not pem:
                 self.fail("No server certificate on svn.python.org:443!")
 
             try:
-                pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=CERTFILE)
+                pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                                 ssl.PROTOCOL_SSLv23,
+                                                 ca_certs=CERTFILE)
             except ssl.SSLError as x:
                 #should fail
                 if support.verbose:
@@ -703,7 +706,9 @@ class NetworkedTests(unittest.TestCase):
             else:
                 self.fail("Got server certificate %s for svn.python.org!" % pem)
 
-            pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
+            pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                             ssl.PROTOCOL_SSLv23,
+                                             ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
             if not pem:
                 self.fail("No server certificate on svn.python.org:443!")
             if support.verbose: