2 bugs found here, added deprecation warning for those who have written their own...

diff --git a/pear/PEAR/Installer-minus-download.php b/pear/PEAR/Installer-minus-download.php
index 33860959b9e184c969a7f8a754b6eb8e538dfd2f..4bc1d1ee6d3a1a1dae2eff040ed47def6ef4759f 100644 (file)
--- a/pear/PEAR/Installer-minus-download.php
+++ b/pear/PEAR/Installer-minus-download.php
@@ -575,6 +575,7 @@ class PEAR_Installer extends PEAR_Downloader
      * @param false private recursion variable
      * @param false private recursion variable
      * @param false private recursion variable
+     * @deprecated in favor of PEAR_Downloader
      */
     function download($packages, $options, &$config, &$installpackages,
                       &$errors, $installed = false, $willinstall = false, $state = false)
@@ -583,6 +584,8 @@ class PEAR_Installer extends PEAR_Downloader
         parent::PEAR_Downloader($this->ui, $options, $config);
         $errors = $this->getErrorMsgs();
         $installpackages = $this->getDownloadedPackages();
+        trigger_error("PEAR Warning: PEAR_Installer::download() is deprecated " .
+                      "in favor of PEAR_Downloader class", E_USER_WARNING);
         return parent::download($packages);
     }