always use (via break) the LDAP connection we're looking at once it's a match,

whether it's used as-is or has just been unbound.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1086433 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/modules/ldap/util_ldap.c b/modules/ldap/util_ldap.c
index a31d583b41ae589a9cb05e90f3931321a833f97f..591d04800f909e2c68097db90016ba9b851fe2cf 100644 (file)
--- a/modules/ldap/util_ldap.c
+++ b/modules/ldap/util_ldap.c
@@ -674,13 +674,10 @@ static util_ldap_connection_t *
                                   "Removing LDAP connection last used %" APR_TIME_T_FMT " seconds ago", 
                                   (now - l->freed) / APR_USEC_PER_SEC);
                     uldap_connection_unbind(l);
-                    /* Go ahead and use it, so we don't create more just to unbind some other old ones */
-                    break; 
+                    /* Go ahead (by falling through) and use it, so we don't create more just to unbind some other old ones */
                 }
             }
-            else { 
-                break;
-            }
+            break;
         }
 #if APR_HAS_THREADS
             /* If this connection didn't match the criteria, then we