Document the fix for perl 5.10 with this comment:

 * The temporary enabling of the caller opcode here is to work around a
 * bug in perl 5.10, which unkindly changed the way its Safe.pm works, without
 * notice. It is quite safe, as caller is informational only, and in any case
 * we only enable it while we load the 'strict' module.

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index 4ac957d1caaffc29163ecd581fa6168bdac9a1ba..452c69cec733be72cbd0677d835ef18ba0397ad6 100644 (file)
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plperl.c - perl as a procedural language for PostgreSQL
  *
- *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.135 2008/01/22 20:17:37 adunstan Exp $
+ *       $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.136 2008/01/23 00:55:47 adunstan Exp $
  *
  **********************************************************************/
 
@@ -260,6 +260,13 @@ _PG_init(void)
 #define SAFE_MODULE \
        "require Safe; $Safe::VERSION"
 
+/* 
+ * The temporary enabling of the caller opcode here is to work around a
+ * bug in perl 5.10, which unkindly changed the way its Safe.pm works, without
+ * notice. It is quite safe, as caller is informational only, and in any case
+ * we only enable it while we load the 'strict' module.
+ */
+
 #define SAFE_OK \
        "use vars qw($PLContainer); $PLContainer = new Safe('PLPerl');" \
        "$PLContainer->permit_only(':default');" \