]> granicus.if.org Git - python/commitdiff
Fix more unbound locals in code paths that do not seem to be used.
authorGeorg Brandl <georg@python.org>
Sat, 6 Feb 2010 23:34:10 +0000 (23:34 +0000)
committerGeorg Brandl <georg@python.org>
Sat, 6 Feb 2010 23:34:10 +0000 (23:34 +0000)
Lib/test/test_cfgparser.py
Lib/test/test_minidom.py
Lib/test/test_platform.py

index c7d6a94e156c062b12a534af4bc4a61afbbd8549..fdd3c0c1c459169797fc056b091e7b5dbc4feaec 100644 (file)
@@ -17,8 +17,9 @@ class SortedDict(UserDict.UserDict):
         return result
 
     def values(self):
+        # XXX never used?
         result = self.items()
-        return [i[1] for i in values]
+        return [i[1] for i in result]
 
     def iteritems(self): return iter(self.items())
     def iterkeys(self): return iter(self.keys())
index b95438dd3827bb3e8c04cc16615004af4628ef3a..7ccb8f40c76c9350e3ec967a03edf04d0d524984 100644 (file)
@@ -1456,12 +1456,13 @@ class MinidomTest(unittest.TestCase):
                 self.confirm(len(n1.entities) == len(n2.entities)
                         and len(n1.notations) == len(n2.notations))
                 for i in range(len(n1.notations)):
+                    # XXX this loop body doesn't seem to be executed?
                     no1 = n1.notations.item(i)
                     no2 = n1.notations.item(i)
                     self.confirm(no1.name == no2.name
                             and no1.publicId == no2.publicId
                             and no1.systemId == no2.systemId)
-                    statck.append((no1, no2))
+                    stack.append((no1, no2))
                 for i in range(len(n1.entities)):
                     e1 = n1.entities.item(i)
                     e2 = n2.entities.item(i)
index b51225e61695e8eb65954447a21e27146e886f47..b9f1a2112386858ff6d0aad92959ef14f0e67fa9 100644 (file)
@@ -182,8 +182,10 @@ class PlatformTest(unittest.TestCase):
         if os.path.isdir(sys.executable) and \
            os.path.exists(sys.executable+'.exe'):
             # Cygwin horror
-            executable = executable + '.exe'
-        res = platform.libc_ver(sys.executable)
+            executable = sys.executable + '.exe'
+        else:
+            executable = sys.executable
+        res = platform.libc_ver(executable)
 
     def test_parse_release_file(self):