mod_http_fileserver: Unregister 'reopen_log_hook'

Unregister the global 'reopen_log_hook' on termination if the module isn't
loaded for another host.

diff --git a/src/mod_http_fileserver.erl b/src/mod_http_fileserver.erl
index ea52eda6b30a6174e234129115b4d490d5e0964d..ac94b58d6162e437857cce48aeb57fe44a64b86e 100644 (file)
--- a/src/mod_http_fileserver.erl
+++ b/src/mod_http_fileserver.erl
@@ -243,11 +243,14 @@ handle_info(Info, State) ->
 %% cleaning up. When it returns, the gen_server terminates with Reason.
 %% The return value is ignored.
 %%--------------------------------------------------------------------
-terminate(_Reason, State) ->
+terminate(_Reason, #state{host = Host} = State) ->
     close_log(State#state.accesslogfd),
-    %% TODO: unregister the hook gracefully
-    %% ejabberd_hooks:delete(reopen_log_hook, State#state.host, ?MODULE, reopen_log, 50),
-    ok.
+    case gen_mod:is_loaded_elsewhere(Host, ?MODULE) of
+       false ->
+           ejabberd_hooks:delete(reopen_log_hook, ?MODULE, reopen_log, 50);
+       true ->
+           ok
+    end.
 
 %%--------------------------------------------------------------------
 %% Func: code_change(OldVsn, State, Extra) -> {ok, NewState}