http_proxy: part of conditional expression is always true: !error
authorDaniel Stenberg <daniel@haxx.se>
Thu, 19 Sep 2019 07:54:12 +0000 (09:54 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Fri, 20 Sep 2019 06:07:28 +0000 (08:07 +0200)
Fixes warning detected by PVS-Studio
Fixes #4374

lib/http_proxy.c

index ba67b861bd13b7a4ed3eaa53bc74293114ec3f0f..710101774a842f3506b749d4048a4b895b09291c 100644 (file)
@@ -327,7 +327,7 @@ static CURLcode CONNECT(struct connectdata *conn,
     { /* READING RESPONSE PHASE */
       int error = SELECT_OK;
 
-      while(s->keepon && !error) {
+      while(s->keepon) {
         ssize_t gotbytes;
 
         /* make sure we have space to read more data */