gv2gxl createNodeId: replace char buffer with an agxbuf

This removes an assumption that `SMALLBUF` is large enough to fit the printed
string. Performance should be unaffected as agxbuf can store a string of the
length printed here inline.

Gitlab: related to #1950

diff --git a/cmd/tools/gv2gxl.c b/cmd/tools/gv2gxl.c
index cdd1ebfb43db0063c6c0e8c1f9e06f21af5c4e5f..a699f4ab0185bf1726195bf0efc86d208fa31b1a 100644 (file)
--- a/cmd/tools/gv2gxl.c
+++ b/cmd/tools/gv2gxl.c
@@ -23,8 +23,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 
-#define SMALLBUF    128
-
 #define EMPTY(s)       ((s == 0) || (*s == '\0'))
 #define SLEN(s)     (sizeof(s)-1)
 
@@ -217,12 +215,16 @@ static char *createGraphId(Dt_t * ids)
 static char *createNodeId(Dt_t * ids)
 {
     static int nodeIdCounter = 0;
-    char buf[SMALLBUF];
+    agxbuf buf = {0};
+    char *name;
 
     do {
-       snprintf(buf, sizeof(buf), "N_%d", nodeIdCounter++);
-    } while (idexists(ids, buf));
-    return addid(ids, buf);
+       agxbprint(&buf, "N_%d", nodeIdCounter++);
+       name = agxbuse(&buf);
+    } while (idexists(ids, name));
+    char *rv = addid(ids, name);
+    agxbfree(&buf);
+    return rv;
 }
 
 static char *mapLookup(Dt_t * nm, char *name)