]> granicus.if.org Git - libvpx/commitdiff
configure: test -Wno-* flags used with libyuv
authorJames Zern <jzern@google.com>
Tue, 4 Jun 2019 21:45:36 +0000 (14:45 -0700)
committerJames Zern <jzern@google.com>
Tue, 4 Jun 2019 21:57:47 +0000 (21:57 +0000)
with g++ this avoids:
command line option ‘-Wno-missing-prototypes’ is valid for C/ObjC but
not for C++

the flag is necessary with clang.

BUG=webm:1584

Change-Id: I250c76483302d913999e5f9e0d09ee6449b052df

build/make/configure.sh
configure
examples.mk

index 8f2928a9dd65c74ad526631189fe9e49a90744cd..e95035350fedbc99917c027295faee9406046985 100644 (file)
@@ -507,6 +507,7 @@ AS_SFX    = ${AS_SFX:-.asm}
 EXE_SFX   = ${EXE_SFX}
 VCPROJ_SFX = ${VCPROJ_SFX}
 RTCD_OPTIONS = ${RTCD_OPTIONS}
+LIBYUV_CXXFLAGS = ${LIBYUV_CXXFLAGS}
 EOF
 
   if enabled rvct; then cat >> $1 << EOF
index 0fd680816461e4a170317ad27d66629ea5fcdabd..d29e00ad86bed9fe8e9deebc600249e44bacbbe2 100755 (executable)
--- a/configure
+++ b/configure
@@ -645,6 +645,14 @@ process_toolchain() {
         if enabled arm; then
           check_add_cxxflags -Wno-psabi
         fi
+
+        # disable some warnings specific to libyuv.
+        check_cxxflags -Wno-missing-declarations \
+          && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-missing-declarations"
+        check_cxxflags -Wno-missing-prototypes \
+          && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-missing-prototypes"
+        check_cxxflags -Wno-unused-parameter \
+          && LIBYUV_CXXFLAGS="${LIBYUV_CXXFLAGS} -Wno-unused-parameter"
     fi
 
     if enabled icc; then
index 208708af7fb78e21ea6a40cea970cb23ba7bf34b..758ca7f88948c74b61365099c5bd8362d92f7ba0 100644 (file)
@@ -77,9 +77,7 @@ vpxdec.SRCS                 += tools_common.c tools_common.h
 vpxdec.SRCS                 += y4menc.c y4menc.h
 ifeq ($(CONFIG_LIBYUV),yes)
   vpxdec.SRCS                 += $(LIBYUV_SRCS)
-  $(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += -Wno-unused-parameter
-  $(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += -Wno-missing-declarations
-  $(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += -Wno-missing-prototypes
+  $(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += ${LIBYUV_CXXFLAGS}
 endif
 ifeq ($(CONFIG_WEBM_IO),yes)
   vpxdec.SRCS                 += $(LIBWEBM_COMMON_SRCS)