]> granicus.if.org Git - clang/commitdiff
Make sure to call AddOverriddenMethods for implicit copy assignment operators;
authorEli Friedman <eli.friedman@gmail.com>
Wed, 2 Dec 2009 06:59:20 +0000 (06:59 +0000)
committerEli Friedman <eli.friedman@gmail.com>
Wed, 2 Dec 2009 06:59:20 +0000 (06:59 +0000)
it's rare, but possible, for the difference to be significant.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@90301 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaDeclCXX.cpp
test/CodeGenCXX/virtual-implicit-copy-assignment.cpp [new file with mode: 0644]

index 3dad051a4e83f4844c0c2d55780101794bc7eccb..7df86ee66c3b117a77e7d133b244e0cba9e95053 100644 (file)
@@ -2149,6 +2149,7 @@ void Sema::AddImplicitlyDeclaredMembersToClass(CXXRecordDecl *ClassDecl) {
     // Don't call addedAssignmentOperator. There is no way to distinguish an
     // implicit from an explicit assignment operator.
     ClassDecl->addDecl(CopyAssignment);
+    AddOverriddenMethods(ClassDecl, CopyAssignment);
   }
 
   if (!ClassDecl->hasUserDeclaredDestructor()) {
diff --git a/test/CodeGenCXX/virtual-implicit-copy-assignment.cpp b/test/CodeGenCXX/virtual-implicit-copy-assignment.cpp
new file mode 100644 (file)
index 0000000..e99b9e6
--- /dev/null
@@ -0,0 +1,10 @@
+// RUN: clang-cc -emit-llvm -o - %s | FileCheck %s
+
+struct D;
+struct B {
+ virtual D& operator = (const D&);
+};
+struct D : B { D(); virtual void a(); };
+void D::a() {}
+
+// CHECK: @_ZTV1D = {{.*}} @_ZN1DaSERKS_