If size is specified, try to read at least size characters.

This is a alternative version of patch #1379332.

diff --git a/Lib/codecs.py b/Lib/codecs.py
index 932f01bec727cc90fa61aab051a247e7251492e8..6895a228fed75a7be16a9be7dab8c925a151a61b 100644 (file)
--- a/Lib/codecs.py
+++ b/Lib/codecs.py
@@ -274,7 +274,10 @@ class StreamReader(Codec):
         while True:
             # can the request can be satisfied from the character buffer?
             if chars < 0:
-                if self.charbuffer:
+                if size < 0:
+                    if self.charbuffer:
+                        break
+                elif len(self.charbuffer) >= size:
                     break
             else:
                 if len(self.charbuffer) >= chars:

diff --git a/Lib/test/test_codecs.py b/Lib/test/test_codecs.py
index ded5d1917a62db1c7f29edd7c995a4961ee141db..3944d654525db6d1cdff848e566b31049bfbc39f 100644 (file)
--- a/Lib/test/test_codecs.py
+++ b/Lib/test/test_codecs.py
@@ -46,19 +46,23 @@ class ReadTest(unittest.TestCase):
             stream = StringIO.StringIO(input.encode(self.encoding))
             return codecs.getreader(self.encoding)(stream)
 
-        def readalllines(input, keepends=True):
+        def readalllines(input, keepends=True, size=None):
             reader = getreader(input)
             lines = []
             while True:
-                line = reader.readline(keepends=keepends)
+                line = reader.readline(size=size, keepends=keepends)
                 if not line:
                     break
                 lines.append(line)
-            return "".join(lines)
+            return "|".join(lines)
 
         s = u"foo\nbar\r\nbaz\rspam\u2028eggs"
-        self.assertEqual(readalllines(s, True), s)
-        self.assertEqual(readalllines(s, False), u"foobarbazspameggs")
+        sexpected = u"foo\n|bar\r\n|baz\r|spam\u2028|eggs"
+        sexpectednoends = u"foo|bar|baz|spam|eggs"
+        self.assertEqual(readalllines(s, True), sexpected)
+        self.assertEqual(readalllines(s, False), sexpectednoends)
+        self.assertEqual(readalllines(s, True, 10), sexpected)
+        self.assertEqual(readalllines(s, False, 10), sexpectednoends)
 
         # Test long lines (multiple calls to read() in readline())
         vw = []