]> granicus.if.org Git - python/commitdiff
Turn the bsddb replication startup timeout test into a
authorR. David Murray <rdmurray@bitdance.com>
Sat, 14 Nov 2009 17:43:16 +0000 (17:43 +0000)
committerR. David Murray <rdmurray@bitdance.com>
Sat, 14 Nov 2009 17:43:16 +0000 (17:43 +0000)
warning, to improve buildbot stability.

Lib/bsddb/test/test_replication.py

index 8e8309b97e3d4f2d5235e8fcc18e66f2fa7ba819..b3775c733037c1cf8393fea761df34507291997e 100644 (file)
@@ -130,8 +130,13 @@ class DBReplicationManager(unittest.TestCase):
             print >> sys.stderr, \
                 "XXX - windows bsddb replication fails on windows and is skipped"
             print >> sys.stderr, "XXX - Please see issue #3892"
-        else:
-            self.assertTrue(time.time()<timeout)
+        # It also fails irregularly on other platforms, and again the
+        # rest of the tests pass.  Since bsddb support is unmaintained, and
+        # is gone in py3k, we just emit a warning instead of a test failure
+        # so as to improve buildbot stability.
+        elif time.time()>timeout:
+            print >> sys.stderr, \
+                "XXX - timeout before startup confirmed, see issue #3892."
 
         d = self.dbenvMaster.repmgr_site_list()
         self.assertEquals(len(d), 1)