PyType_stgdict() returns a borrowed reference which must not be Py_DECREF'd.

This bug should be fixed in trunk and release25-maint also.

diff --git a/Modules/_ctypes/stgdict.c b/Modules/_ctypes/stgdict.c
index 07e142bdfe0675a0b01b0fc5904c12492578d160..c35a5154e965d58790d9b85e360448e0fa62f988 100644 (file)
--- a/Modules/_ctypes/stgdict.c
+++ b/Modules/_ctypes/stgdict.c
@@ -465,13 +465,11 @@ StructUnionType_update_stgdict(PyObject *type, PyObject *fields, int isStruct)
 
                if (!prop) {
                        Py_DECREF(pair);
-                       Py_DECREF((PyObject *)stgdict);
                        return -1;
                }
                if (-1 == PyDict_SetItem(realdict, name, prop)) {
                        Py_DECREF(prop);
                        Py_DECREF(pair);
-                       Py_DECREF((PyObject *)stgdict);
                        return -1;
                }
                Py_DECREF(pair);