fixed 3 of the "nits" flagged by Remi

diff --git a/pdns/dnsdist.hh b/pdns/dnsdist.hh
index cbd3ebdd950a44f31d3fce87f1a8e1c9bdbb9310..1763c060a977d97b48a312cb41558d59494cd62d 100644 (file)
--- a/pdns/dnsdist.hh
+++ b/pdns/dnsdist.hh
@@ -68,7 +68,7 @@ QTag()
 {
 }
 
-void add(std::string strLabel, std::string strValue)
+void add(const std::string strLabel, const std::string strValue)
 {
   tagData.insert( {strLabel, strValue});
   return;
@@ -126,7 +126,7 @@ public:
   std::unordered_map<std::string, std::string>tagData;
 
 private:
-  const char *strSep = "\t";
+  static constexpr char const *strSep = "\t";
 };
 
 

diff --git a/pdns/protobuf.cc b/pdns/protobuf.cc
index a2acc254b7dae9a31c6ffe77f47e144c7771a159..6cf8e826a8935c9cd446b90ceb887360537933f5 100644 (file)
--- a/pdns/protobuf.cc
+++ b/pdns/protobuf.cc
@@ -123,7 +123,7 @@ void DNSProtoBufMessage::addRR(const std::string& strName, uint16_t uType, uint1
     rr->set_type(uType);
     rr->set_class_(uClass);
     rr->set_ttl(uTTL);
-    rr->set_rdata((const uint8_t *) strBlob.c_str(), strBlob.size());
+    rr->set_rdata(strBlob.c_str(), strBlob.size());
   }
 
 #endif /* HAVE_PROTOBUF */