{
tr_ctorSetMetainfo (ctor, fileContents, fileLength);
}
- else if (!memcmp (torrentPath, "magnet:?", 8))
+ else if (memcmp (torrentPath, "magnet:?", 8) == 0)
{
tr_ctorSetMetainfoFromMagnetLink (ctor, torrentPath);
}
- else if (!memcmp (torrentPath, "http", 4))
+ else if (memcmp (torrentPath, "http", 4) == 0)
{
tr_webRun (h, torrentPath, onTorrentFileDownloaded, ctor);
waitingOnWeb = true;
}
}
- if (!tr_strcmp0 (id, "active"))
+ if (tr_strcmp0 (id, "active") == 0)
{
tr_variantDictAddStr (args, TR_KEY_ids, "recently-active");
}
- else if (strcmp (id, "all"))
+ else if (strcmp (id, "all") != 0)
{
const char * pch;
bool isList = strchr (id,',') || strchr (id,'-');
arg = "-1"; /* no file will have this index, so should be a no-op */
}
- if (strcmp (arg, "all"))
+ if (strcmp (arg, "all") != 0)
{
int i;
int valueCount;
const char * key = TR_RPC_SESSION_ID_HEADER ": ";
const size_t key_len = strlen (key);
- if ((line_len >= key_len) && !memcmp (line, key, key_len))
+ if (line_len >= key_len && memcmp (line, key, key_len) == 0)
{
const char * begin = line + key_len;
const char * end = begin;
if (tr_variantDictFindStr (&top, TR_KEY_result, &str, NULL))
{
- if (strcmp (str, "success"))
+ if (strcmp (str, "success") != 0)
{
printf ("Error: %s\n", str);
status |= EXIT_FAILURE;
status |= EXIT_FAILURE;
else {
printf ("%s responded: \"%s\"\n", rpcurl, str);
- if (strcmp (str, "success"))
+ if (strcmp (str, "success") != 0)
status |= EXIT_FAILURE;
}
}
int i;
const char * s = argv[1];
const char * delim = strchr (s, ':');
- if (!strncmp (s, "http://", 7)) /* user passed in http rpc url */
+ if (strncmp (s, "http://", 7) == 0) /* user passed in http rpc url */
{
*rpcurl = tr_strdup_printf ("%s/rpc/", s + 7);
}
- else if (!strncmp (s, "https://", 8)) /* user passed in https rpc url */
+ else if (strncmp (s, "https://", 8) == 0) /* user passed in https rpc url */
{
UseSSL = true;
*rpcurl = tr_strdup_printf ("%s/rpc/", s + 8);
match = gtr_pref_string_get (TR_KEY_sort_mode);
for (i = 0, n = G_N_ELEMENTS (sort_radio_entries), active = -1; active == -1 && i < n; ++i)
- if (!g_strcmp0 (sort_radio_entries[i].name, match))
+ if (g_strcmp0 (sort_radio_entries[i].name, match) == 0)
active = i;
gtk_action_group_add_radio_actions (action_group,
gtk_text_buffer_get_bounds (b, &start, &end);
old_str = gtk_text_buffer_get_text (b, &start, &end, FALSE);
- if ((old_str == NULL) || g_strcmp0 (old_str, str))
+ if (old_str == NULL || g_strcmp0 (old_str, str) != 0)
gtk_text_buffer_set_text (b, str, -1);
g_free (old_str);
for (i=1; i<n; ++i)
{
- mixed_creator |= g_strcmp0 (creator, infos[i]->creator ? infos[i]->creator : "");
+ mixed_creator |= g_strcmp0 (creator, infos[i]->creator ? infos[i]->creator : "") != 0;
mixed_date |= (date != infos[i]->dateCreated);
}
const char * baseline = infos[0]->comment ? infos[0]->comment : "";
for (i=1; i<n; ++i)
- if (g_strcmp0 (baseline, infos[i]->comment ? infos[i]->comment : ""))
+ if (g_strcmp0 (baseline, infos[i]->comment ? infos[i]->comment : "") != 0)
break;
if (i==n)
const char * baseline = tr_torrentGetDownloadDir (torrents[0]);
for (i=1; i<n; ++i)
- if (g_strcmp0 (baseline, tr_torrentGetDownloadDir (torrents[i])))
+ if (g_strcmp0 (baseline, tr_torrentGetDownloadDir (torrents[i])) != 0)
break;
if (i==n)
const char * baseline = stats[0]->errorString;
for (i=1; i<n; ++i)
- if (g_strcmp0 (baseline, stats[i]->errorString))
+ if (g_strcmp0 (baseline, stats[i]->errorString) != 0)
break;
if (i==n)
char collated_name[128];
const char * client = peer->client;
- if (!client || !g_strcmp0 (client, "Unknown Client"))
+ if (client == NULL || g_strcmp0 (client, "Unknown Client") == 0)
client = "";
if (sscanf (peer->addr, "%d.%d.%d.%d", q, q+1, q+2, q+3) != 4)
while (child)
{
const struct row_struct * child_data = child->data;
- if ((*child_data->name == *name) && !g_strcmp0 (child_data->name, name))
+ if (*child_data->name == *name && g_strcmp0 (child_data->name, name) == 0)
break;
child = child->next;
}
}
for (k=0; k<keyCount; ++k)
- if (!g_strcmp0 (keys[k], key))
+ if (g_strcmp0 (keys[k], key) == 0)
break;
if (k==keyCount)
for (i=0; i<inf->trackerCount; ++i)
{
gtr_get_host_from_url (tmp, sizeof (tmp), inf->trackers[i].announce);
- if (!g_strcmp0 (tmp, host))
+ if (g_strcmp0 (tmp, host) == 0)
break;
}
char * key = get_details_dialog_key (ids);
for (l=data->details; dialog==NULL && l!=NULL; l=l->next)
- if (!g_strcmp0 (key, g_object_get_data (l->data, "key")))
+ if (g_strcmp0 (key, g_object_get_data (l->data, "key")) == 0)
dialog = l->data;
if (dialog == NULL)
gboolean changed = FALSE;
struct cbdata * data = user_data;
- if (!g_strcmp0 (action_name, "open-torrent-from-url"))
+ if (g_strcmp0 (action_name, "open-torrent-from-url") == 0)
{
GtkWidget * w = gtr_torrent_open_from_url_dialog_new (data->wind, data->core);
gtk_widget_show (w);
}
- else if (!g_strcmp0 (action_name, "open-torrent-menu")
- || !g_strcmp0 (action_name, "open-torrent-toolbar"))
+ else if (g_strcmp0 (action_name, "open-torrent-menu") == 0
+ || g_strcmp0 (action_name, "open-torrent-toolbar") == 0)
{
GtkWidget * w = gtr_torrent_open_from_file_dialog_new (data->wind, data->core);
gtk_widget_show (w);
}
- else if (!g_strcmp0 (action_name, "show-stats"))
+ else if (g_strcmp0 (action_name, "show-stats") == 0)
{
GtkWidget * dialog = gtr_stats_dialog_new (data->wind, data->core);
gtk_widget_show (dialog);
}
- else if (!g_strcmp0 (action_name, "donate"))
+ else if (g_strcmp0 (action_name, "donate") == 0)
{
gtr_open_uri ("http://www.transmissionbt.com/donate.php");
}
- else if (!g_strcmp0 (action_name, "pause-all-torrents"))
+ else if (g_strcmp0 (action_name, "pause-all-torrents") == 0)
{
pause_all_torrents (data);
}
- else if (!g_strcmp0 (action_name, "start-all-torrents"))
+ else if (g_strcmp0 (action_name, "start-all-torrents") == 0)
{
start_all_torrents (data);
}
- else if (!g_strcmp0 (action_name, "copy-magnet-link-to-clipboard"))
+ else if (g_strcmp0 (action_name, "copy-magnet-link-to-clipboard") == 0)
{
tr_torrent * tor = get_first_selected_torrent (data);
if (tor != NULL)
copy_magnet_link_to_clipboard (GTK_WIDGET (data->wind), tor);
}
}
- else if (!g_strcmp0 (action_name, "relocate-torrent"))
+ else if (g_strcmp0 (action_name, "relocate-torrent") == 0)
{
GSList * ids = get_selected_torrent_ids (data);
if (ids != NULL)
gtk_widget_show (w);
}
}
- else if (!g_strcmp0 (action_name, "torrent-start")
- || !g_strcmp0 (action_name, "torrent-start-now")
- || !g_strcmp0 (action_name, "torrent-stop")
- || !g_strcmp0 (action_name, "torrent-reannounce")
- || !g_strcmp0 (action_name, "torrent-verify")
- || !g_strcmp0 (action_name, "queue-move-top")
- || !g_strcmp0 (action_name, "queue-move-up")
- || !g_strcmp0 (action_name, "queue-move-down")
- || !g_strcmp0 (action_name, "queue-move-bottom"))
+ else if (g_strcmp0 (action_name, "torrent-start") == 0
+ || g_strcmp0 (action_name, "torrent-start-now") == 0
+ || g_strcmp0 (action_name, "torrent-stop") == 0
+ || g_strcmp0 (action_name, "torrent-reannounce") == 0
+ || g_strcmp0 (action_name, "torrent-verify") == 0
+ || g_strcmp0 (action_name, "queue-move-top") == 0
+ || g_strcmp0 (action_name, "queue-move-up") == 0
+ || g_strcmp0 (action_name, "queue-move-down") == 0
+ || g_strcmp0 (action_name, "queue-move-bottom") == 0)
{
changed |= call_rpc_for_selected_torrents (data, action_name);
}
- else if (!g_strcmp0 (action_name, "open-torrent-folder"))
+ else if (g_strcmp0 (action_name, "open-torrent-folder") == 0)
{
gtk_tree_selection_selected_foreach (data->sel, open_folder_foreach, data->core);
}
- else if (!g_strcmp0 (action_name, "show-torrent-properties"))
+ else if (g_strcmp0 (action_name, "show-torrent-properties") == 0)
{
show_details_dialog_for_selected_torrents (data);
}
- else if (!g_strcmp0 (action_name, "new-torrent"))
+ else if (g_strcmp0 (action_name, "new-torrent") == 0)
{
GtkWidget * w = gtr_torrent_creation_dialog_new (data->wind, data->core);
gtk_widget_show (w);
}
- else if (!g_strcmp0 (action_name, "remove-torrent"))
+ else if (g_strcmp0 (action_name, "remove-torrent") == 0)
{
remove_selected (data, FALSE);
}
- else if (!g_strcmp0 (action_name, "delete-torrent"))
+ else if (g_strcmp0 (action_name, "delete-torrent") == 0)
{
remove_selected (data, TRUE);
}
- else if (!g_strcmp0 (action_name, "quit"))
+ else if (g_strcmp0 (action_name, "quit") == 0)
{
on_app_exit (data);
}
- else if (!g_strcmp0 (action_name, "select-all"))
+ else if (g_strcmp0 (action_name, "select-all") == 0)
{
gtk_tree_selection_select_all (data->sel);
}
- else if (!g_strcmp0 (action_name, "deselect-all"))
+ else if (g_strcmp0 (action_name, "deselect-all") == 0)
{
gtk_tree_selection_unselect_all (data->sel);
}
- else if (!g_strcmp0 (action_name, "edit-preferences"))
+ else if (g_strcmp0 (action_name, "edit-preferences") == 0)
{
if (NULL == data->prefs)
{
}
gtr_window_present (GTK_WINDOW (data->prefs));
}
- else if (!g_strcmp0 (action_name, "toggle-message-log"))
+ else if (g_strcmp0 (action_name, "toggle-message-log") == 0)
{
if (!data->msgwin)
{
data->msgwin = NULL;
}
}
- else if (!g_strcmp0 (action_name, "show-about-dialog"))
+ else if (g_strcmp0 (action_name, "show-about-dialog") == 0)
{
show_about_dialog (data->wind);
}
- else if (!g_strcmp0 (action_name, "help"))
+ else if (g_strcmp0 (action_name, "help") == 0)
{
gtr_open_uri (gtr_get_help_uri ());
}
- else if (!g_strcmp0 (action_name, "toggle-main-window"))
+ else if (g_strcmp0 (action_name, "toggle-main-window") == 0)
{
toggleMainWindow (data);
}
- else if (!g_strcmp0 (action_name, "present-main-window"))
+ else if (g_strcmp0 (action_name, "present-main-window") == 0)
{
presentMainWindow (data);
}
GtkSortType type = is_reversed ? GTK_SORT_ASCENDING : GTK_SORT_DESCENDING;
GtkTreeSortable * sortable = GTK_TREE_SORTABLE (gtr_core_model (core));
- if (!g_strcmp0 (mode, "sort-by-activity"))
+ if (g_strcmp0 (mode, "sort-by-activity") == 0)
sort_func = compare_by_activity;
- else if (!g_strcmp0 (mode, "sort-by-age"))
+ else if (g_strcmp0 (mode, "sort-by-age") == 0)
sort_func = compare_by_age;
- else if (!g_strcmp0 (mode, "sort-by-progress"))
+ else if (g_strcmp0 (mode, "sort-by-progress") == 0)
sort_func = compare_by_progress;
- else if (!g_strcmp0 (mode, "sort-by-queue"))
+ else if (g_strcmp0 (mode, "sort-by-queue") == 0)
sort_func = compare_by_queue;
- else if (!g_strcmp0 (mode, "sort-by-time-left"))
+ else if (g_strcmp0 (mode, "sort-by-time-left") == 0)
sort_func = compare_by_eta;
- else if (!g_strcmp0 (mode, "sort-by-ratio"))
+ else if (g_strcmp0 (mode, "sort-by-ratio") == 0)
sort_func = compare_by_ratio;
- else if (!g_strcmp0 (mode, "sort-by-state"))
+ else if (g_strcmp0 (mode, "sort-by-state") == 0)
sort_func = compare_by_state;
- else if (!g_strcmp0 (mode, "sort-by-size"))
+ else if (g_strcmp0 (mode, "sort-by-size") == 0)
sort_func = compare_by_size;
else {
sort_func = compare_by_name;
void
gtr_core_set_pref (TrCore * self, const tr_quark key, const char * newval)
{
- if (g_strcmp0 (newval, gtr_pref_string_get (key)))
+ if (g_strcmp0 (newval, gtr_pref_string_get (key)) != 0)
{
gtr_pref_string_set (key, newval);
core_commit_prefs_change (self, key);
const char * val = stats_modes[i].val;
w = gtk_radio_menu_item_new_with_label (l, _ (stats_modes[i].i18n));
l = gtk_radio_menu_item_get_group (GTK_RADIO_MENU_ITEM (w));
- gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (w), !g_strcmp0 (val, pch));
+ gtk_check_menu_item_set_active (GTK_CHECK_MENU_ITEM (w), g_strcmp0 (val, pch) == 0);
g_object_set_data (G_OBJECT (w), STATS_MODE, (gpointer)stats_modes[i].val);
g_signal_connect (w, "toggled", G_CALLBACK (status_menu_toggled_cb), p);
gtk_menu_shell_append (GTK_MENU_SHELL (menu), w);
/* update the stats */
pch = gtr_pref_string_get (TR_KEY_statusbar_stats);
- if (!g_strcmp0 (pch, "session-ratio"))
+ if (g_strcmp0 (pch, "session-ratio") == 0)
{
tr_sessionGetStats (session, &stats);
tr_strlratio (ratio, stats.ratio, sizeof (ratio));
g_snprintf (buf, sizeof (buf), _("Ratio: %s"), ratio);
}
- else if (!g_strcmp0 (pch, "session-transfer"))
+ else if (g_strcmp0 (pch, "session-transfer") == 0)
{
tr_sessionGetStats (session, &stats);
tr_strlsize (up, stats.uploadedBytes, sizeof (up));
g_snprintf (buf, sizeof (buf),
Q_("Down: %1$s, Up: %2$s"), down, up);
}
- else if (!g_strcmp0 (pch, "total-transfer"))
+ else if (g_strcmp0 (pch, "total-transfer") == 0)
{
tr_sessionGetCumulativeStats (session, &stats);
tr_strlsize (up, stats.uploadedBytes, sizeof (up));
{
const char * oldstr = gtk_label_get_text (lb);
- if (g_strcmp0 (oldstr, newstr))
+ if (g_strcmp0 (oldstr, newstr) != 0)
gtk_label_set_text (lb, newstr);
}
for (j=0; j<response->row_count; ++j)
{
struct tr_scrape_response_row * row = &response->rows[j];
- if (!memcmp (tr_quark_get_string(key,NULL), row->info_hash, SHA_DIGEST_LENGTH))
+ if (memcmp (tr_quark_get_string (key, NULL), row->info_hash, SHA_DIGEST_LENGTH) == 0)
{
if (tr_variantDictFindInt (val, TR_KEY_complete, &intVal))
row->seeders = intVal;
key = tr_strdup_printf ("%s:%d", host, port);
for (i=0, n=tr_ptrArraySize (&tau->trackers); !tracker && i<n; ++i) {
struct tau_tracker * tmp = tr_ptrArrayNth (&tau->trackers, i);
- if (!tr_strcmp0 (tmp->key, key))
+ if (tr_strcmp0 (tmp->key, key) == 0)
tracker = tmp;
}
return i;
/* secondary key: the torrent's info_hash */
- if ((i = memcmp (a->info_hash, b->info_hash, SHA_DIGEST_LENGTH)))
+ if ((i = memcmp (a->info_hash, b->info_hash, SHA_DIGEST_LENGTH)) != 0)
return i;
/* tertiary key: the tracker's announec url */
*/
for (j=0, jn=n; !is_duplicate && j<jn; ++j)
is_duplicate = (tmp[j].port==port)
- && !strcmp (tmp[j].scheme,scheme)
- && !strcmp (tmp[j].host,host)
- && !strcmp (tmp[j].path,path);
+ && strcmp (tmp[j].scheme, scheme) == 0
+ && strcmp (tmp[j].host, host) == 0
+ && strcmp (tmp[j].path, path) == 0;
if (is_duplicate) {
tr_free (path);
for (j=i+1, jn=n; j<jn; ++j)
if ((tmp[i].info.tier!=tmp[j].info.tier)
&& (tmp[i].port==tmp[j].port)
- && !tr_strcmp0 (tmp[i].host,tmp[j].host)
- && !tr_strcmp0 (tmp[i].path,tmp[j].path))
+ && tr_strcmp0 (tmp[i].host, tmp[j].host) == 0
+ && tr_strcmp0 (tmp[i].path, tmp[j].path) == 0)
tmp[j].info.tier = tmp[i].info.tier;
/* sort them, for two reasons:
request->peer_id);
#endif
- if (!memcmp (request->url, "http", 4))
+ if (memcmp (request->url, "http", 4) == 0)
tr_tracker_http_announce (session, request, callback, callback_data);
- else if (!memcmp (request->url, "udp://", 6))
+ else if (memcmp (request->url, "udp://", 6) == 0)
tr_tracker_udp_announce (session, request, callback, callback_data);
else
tr_logAddError ("Unsupported url: %s", request->url);
for (i=0; tt && i<tt->tier_count; ++i) {
const tr_tracker * const tracker = tt->tiers[i].currentTracker;
- if (tracker && !tr_strcmp0 (scrape, tracker->scrape))
+ if (tracker != NULL && tr_strcmp0 (scrape, tracker->scrape) == 0)
return &tt->tiers[i];
}
{
tr_session * session = announcer->session;
- if (!memcmp (request->url, "http", 4))
+ if (memcmp (request->url, "http", 4) == 0)
tr_tracker_http_scrape (session, request, callback, callback_data);
- else if (!memcmp (request->url, "udp://", 6))
+ else if (memcmp (request->url, "udp://", 6) == 0)
tr_tracker_udp_scrape (session, request, callback, callback_data);
else
tr_logAddError ("Unsupported url: %s", request->url);
if (req->info_hash_count >= TR_MULTISCRAPE_MAX)
continue;
- if (tr_strcmp0 (req->url, url))
+ if (tr_strcmp0 (req->url, url) != 0)
continue;
memcpy (req->info_hash[req->info_hash_count++], hash, SHA_DIGEST_LENGTH);
/* sanity clause */
assert (trackerIndex < tgt->tracker_count);
- assert (!tr_strcmp0 (tgt->trackers[trackerIndex].announce, src->currentTracker->announce));
+ assert (tr_strcmp0 (tgt->trackers[trackerIndex].announce, src->currentTracker->announce) == 0);
/* bitwise copy will handle most of tr_tier's fields... */
*tgt = *src;
/* find a tier (if any) which has a match for src->currentTracker */
for (i=0; !found && i<tt->tier_count; ++i)
for (j=0; !found && j<tt->tiers[i].tracker_count; ++j)
- if ((found = !tr_strcmp0 (src->currentTracker->announce, tt->tiers[i].trackers[j].announce)))
+ if ((found = tr_strcmp0 (src->currentTracker->announce, tt->tiers[i].trackers[j].announce) == 0))
copy_tier_attributes_impl (&tt->tiers[i], j, src);
}
static bool
decodeBitCometClient (char * buf, size_t buflen, const uint8_t * id)
{
- int is_bitlord;
+ bool is_bitlord;
int major, minor;
const char * name;
const char * mod = NULL;
- if (!memcmp (id, "exbc", 4)) mod = "";
- else if (!memcmp (id, "FUTB", 4)) mod = " (Solidox Mod) ";
- else if (!memcmp (id, "xUTB", 4)) mod = " (Mod 2) ";
+ if (memcmp (id, "exbc", 4) == 0) mod = "";
+ else if (memcmp (id, "FUTB", 4) == 0) mod = " (Solidox Mod) ";
+ else if (memcmp (id, "xUTB", 4) == 0) mod = " (Mod 2) ";
else return false;
- is_bitlord = !memcmp (id+6, "LORD", 4);
+ is_bitlord = memcmp (id+6, "LORD", 4) == 0;
name = (is_bitlord) ? "BitLord " : "BitComet ";
major = id[4];
minor = id[5];
/* Azureus-style */
if (id[0] == '-' && id[7] == '-')
{
- if (!memcmp (id+1, "TR", 2))
+ if (memcmp (id+1, "TR", 2) == 0)
{
- if (!memcmp (id+3, "000", 3)) /* very old client style: -TR0006- is 0.6 */
+ if (memcmp (id+3, "000", 3) == 0) /* very old client style: -TR0006- is 0.6 */
tr_snprintf (buf, buflen, "Transmission 0.%c", id[6]);
- else if (!memcmp (id+3, "00", 2)) /* previous client style: -TR0072- is 0.72 */
+ else if (memcmp (id+3, "00", 2) == 0) /* previous client style: -TR0072- is 0.72 */
tr_snprintf (buf, buflen, "Transmission 0.%02d", strint (id+5,2));
else /* current client style: -TR111Z- is 1.11+ */
tr_snprintf (buf, buflen, "Transmission %d.%02d%s", strint (id+3,1), strint (id+4,2),
id[6]=='Z' || id[6]=='X' ? "+" : "");
}
- else if (!memcmp (id+1, "UT", 2))
+ else if (memcmp (id+1, "UT", 2) == 0)
{
tr_snprintf (buf, buflen, "\xc2\xb5Torrent %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,1), getMnemonicEnd (id[6]));
}
- else if (!memcmp (id+1, "BT", 2))
+ else if (memcmp (id+1, "BT", 2) == 0)
{
tr_snprintf (buf, buflen, "BitTorrent %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,1), getMnemonicEnd (id[6]));
}
- else if (!memcmp (id+1, "UM", 2))
+ else if (memcmp (id+1, "UM", 2) == 0)
{
tr_snprintf (buf, buflen, "\xc2\xb5Torrent Mac %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,1), getMnemonicEnd (id[6]));
}
- else if (!memcmp (id+1, "UE", 2))
+ else if (memcmp (id+1, "UE", 2) == 0)
{
tr_snprintf (buf, buflen, "\xc2\xb5Torrent Embedded %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,1), getMnemonicEnd (id[6]));
}
- else if (!memcmp (id+1, "AZ", 2))
+ else if (memcmp (id+1, "AZ", 2) == 0)
{
if (id[3] > '3' || (id[3] == '3' && id[4] >= '1')) /* Vuze starts at version 3.1.0.0 */
four_digits (buf, buflen, "Vuze", id+3);
four_digits (buf, buflen, "Azureus", id+3);
}
- else if (!memcmp (id+1, "KT", 2))
+ else if (memcmp (id+1, "KT", 2) == 0)
{
if (id[5] == 'D')
tr_snprintf (buf, buflen, "KTorrent %d.%d Dev %d", charint (id[3]), charint (id[4]), charint (id[6]));
three_digits (buf, buflen, "KTorrent", id+3);
}
- else if (!memcmp (id+1, "AG", 2)) four_digits (buf, buflen, "Ares", id+3);
- else if (!memcmp (id+1, "AR", 2)) four_digits (buf, buflen, "Arctic", id+3);
- else if (!memcmp (id+1, "AT", 2)) four_digits (buf, buflen, "Artemis", id+3);
- else if (!memcmp (id+1, "AV", 2)) four_digits (buf, buflen, "Avicora", id+3);
- else if (!memcmp (id+1, "BB", 2)) four_digits (buf, buflen, "BitBuddy", id+3);
- else if (!memcmp (id+1, "BE", 2)) four_digits (buf, buflen, "BitTorrent SDK", id+3);
- else if (!memcmp (id+1, "BG", 2)) four_digits (buf, buflen, "BTGetit", id+3);
- else if (!memcmp (id+1, "BH", 2)) four_digits (buf, buflen, "BitZilla", id+3);
- else if (!memcmp (id+1, "BM", 2)) four_digits (buf, buflen, "BitMagnet", id+3);
- else if (!memcmp (id+1, "BP", 2)) four_digits (buf, buflen, "BitTorrent Pro (Azureus + Spyware)", id+3);
- else if (!memcmp (id+1, "BX", 2)) four_digits (buf, buflen, "BittorrentX", id+3);
- else if (!memcmp (id+1, "bk", 2)) four_digits (buf, buflen, "BitKitten (libtorrent)", id+3);
- else if (!memcmp (id+1, "BS", 2)) four_digits (buf, buflen, "BTSlave", id+3);
- else if (!memcmp (id+1, "BW", 2)) four_digits (buf, buflen, "BitWombat", id+3);
- else if (!memcmp (id+1, "BX", 2)) four_digits (buf, buflen, "BittorrentX", id+3);
- else if (!memcmp (id+1, "EB", 2)) four_digits (buf, buflen, "EBit", id+3);
- else if (!memcmp (id+1, "DE", 2)) four_digits (buf, buflen, "Deluge", id+3);
- else if (!memcmp (id+1, "DP", 2)) four_digits (buf, buflen, "Propogate Data Client", id+3);
- else if (!memcmp (id+1, "FC", 2)) four_digits (buf, buflen, "FileCroc", id+3);
- else if (!memcmp (id+1, "FT", 2)) four_digits (buf, buflen, "FoxTorrent/RedSwoosh", id+3);
- else if (!memcmp (id+1, "GR", 2)) four_digits (buf, buflen, "GetRight", id+3);
- else if (!memcmp (id+1, "GS", 2)) four_digits (buf, buflen, "GSTorrent", id+3);
- else if (!memcmp (id+1, "HK", 2)) four_digits (buf, buflen, "Hekate", id+3);
- else if (!memcmp (id+1, "HN", 2)) four_digits (buf, buflen, "Hydranode", id+3);
- else if (!memcmp (id+1, "KG", 2)) four_digits (buf, buflen, "KGet", id+3);
- else if (!memcmp (id+1, "LC", 2)) four_digits (buf, buflen, "LeechCraft", id+3);
- else if (!memcmp (id+1, "LH", 2)) four_digits (buf, buflen, "LH-ABC", id+3);
- else if (!memcmp (id+1, "NX", 2)) four_digits (buf, buflen, "Net Transport", id+3);
- else if (!memcmp (id+1, "MK", 2)) four_digits (buf, buflen, "Meerkat", id+3);
- else if (!memcmp (id+1, "MO", 2)) four_digits (buf, buflen, "MonoTorrent", id+3);
- else if (!memcmp (id+1, "MR", 2)) four_digits (buf, buflen, "Miro", id+3);
- else if (!memcmp (id+1, "MT", 2)) four_digits (buf, buflen, "Moonlight", id+3);
- else if (!memcmp (id+1, "OS", 2)) four_digits (buf, buflen, "OneSwarm", id+3);
- else if (!memcmp (id+1, "OT", 2)) four_digits (buf, buflen, "OmegaTorrent", id+3);
- else if (!memcmp (id+1, "PD", 2)) four_digits (buf, buflen, "Pando", id+3);
- else if (!memcmp (id+1, "QD", 2)) four_digits (buf, buflen, "QQDownload", id+3);
- else if (!memcmp (id+1, "RS", 2)) four_digits (buf, buflen, "Rufus", id+3);
- else if (!memcmp (id+1, "RT", 2)) four_digits (buf, buflen, "Retriever", id+3);
- else if (!memcmp (id+1, "RZ", 2)) four_digits (buf, buflen, "RezTorrent", id+3);
- else if (!memcmp (id+1, "SD", 2)) four_digits (buf, buflen, "Thunder", id+3);
- else if (!memcmp (id+1, "SM", 2)) four_digits (buf, buflen, "SoMud", id+3);
- else if (!memcmp (id+1, "SS", 2)) four_digits (buf, buflen, "SwarmScope", id+3);
- else if (!memcmp (id+1, "ST", 2)) four_digits (buf, buflen, "SymTorrent", id+3);
- else if (!memcmp (id+1, "SZ", 2)) four_digits (buf, buflen, "Shareaza", id+3);
- else if (!memcmp (id+1, "S~", 2)) four_digits (buf, buflen, "Shareaza", id+3);
- else if (!memcmp (id+1, "st", 2)) four_digits (buf, buflen, "SharkTorrent", id+3);
- else if (!memcmp (id+1, "TN", 2)) four_digits (buf, buflen, "Torrent .NET", id+3);
- else if (!memcmp (id+1, "TS", 2)) four_digits (buf, buflen, "TorrentStorm", id+3);
- else if (!memcmp (id+1, "TT", 2)) four_digits (buf, buflen, "TuoTu", id+3);
- else if (!memcmp (id+1, "UL", 2)) four_digits (buf, buflen, "uLeecher!", id+3);
- else if (!memcmp (id+1, "VG", 2)) four_digits (buf, buflen, "Vagaa", id+3);
- else if (!memcmp (id+1, "WT", 2)) four_digits (buf, buflen, "BitLet", id+3);
- else if (!memcmp (id+1, "WY", 2)) four_digits (buf, buflen, "FireTorrent", id+3);
- else if (!memcmp (id+1, "XL", 2)) four_digits (buf, buflen, "Xunlei", id+3);
- else if (!memcmp (id+1, "XS", 2)) four_digits (buf, buflen, "XSwifter", id+3);
- else if (!memcmp (id+1, "XT", 2)) four_digits (buf, buflen, "XanTorrent", id+3);
- else if (!memcmp (id+1, "XX", 2)) four_digits (buf, buflen, "Xtorrent", id+3);
- else if (!memcmp (id+1, "ZT", 2)) four_digits (buf, buflen, "Zip Torrent", id+3);
- else if (!memcmp (id+1, "ZO", 2)) four_digits (buf, buflen, "Zona", id+3);
-
- else if (!memcmp (id+1, "AG", 2)) three_digits (buf, buflen, "Ares", id+3);
- else if (!memcmp (id+1, "A~", 2)) three_digits (buf, buflen, "Ares", id+3);
- else if (!memcmp (id+1, "ES", 2)) three_digits (buf, buflen, "Electric Sheep", id+3);
- else if (!memcmp (id+1, "HL", 2)) three_digits (buf, buflen, "Halite", id+3);
- else if (!memcmp (id+1, "LT", 2)) three_digits (buf, buflen, "libtorrent (Rasterbar)", id+3);
- else if (!memcmp (id+1, "lt", 2)) three_digits (buf, buflen, "libTorrent (Rakshasa)", id+3);
- else if (!memcmp (id+1, "MP", 2)) three_digits (buf, buflen, "MooPolice", id+3);
- else if (!memcmp (id+1, "pb", 2)) three_digits (buf, buflen, "pbTorrent", id+3);
- else if (!memcmp (id+1, "TT", 2)) three_digits (buf, buflen, "TuoTu", id+3);
- else if (!memcmp (id+1, "qB", 2)) three_digits (buf, buflen, "qBittorrent", id+3);
-
- else if (!memcmp (id+1, "AX", 2)) two_major_two_minor (buf, buflen, "BitPump", id+3);
- else if (!memcmp (id+1, "BC", 2)) two_major_two_minor (buf, buflen, "BitComet", id+3);
- else if (!memcmp (id+1, "CD", 2)) two_major_two_minor (buf, buflen, "Enhanced CTorrent", id+3);
- else if (!memcmp (id+1, "LP", 2)) two_major_two_minor (buf, buflen, "Lphant", id+3);
-
- else if (!memcmp (id+1, "BF", 2)) no_version (buf, buflen, "BitFlu");
- else if (!memcmp (id+1, "LW", 2)) no_version (buf, buflen, "LimeWire");
-
- else if (!memcmp (id+1, "BB", 2))
+ else if (memcmp (id+1, "AG", 2) == 0) four_digits (buf, buflen, "Ares", id+3);
+ else if (memcmp (id+1, "AR", 2) == 0) four_digits (buf, buflen, "Arctic", id+3);
+ else if (memcmp (id+1, "AT", 2) == 0) four_digits (buf, buflen, "Artemis", id+3);
+ else if (memcmp (id+1, "AV", 2) == 0) four_digits (buf, buflen, "Avicora", id+3);
+ else if (memcmp (id+1, "BB", 2) == 0) four_digits (buf, buflen, "BitBuddy", id+3);
+ else if (memcmp (id+1, "BE", 2) == 0) four_digits (buf, buflen, "BitTorrent SDK", id+3);
+ else if (memcmp (id+1, "BG", 2) == 0) four_digits (buf, buflen, "BTGetit", id+3);
+ else if (memcmp (id+1, "BH", 2) == 0) four_digits (buf, buflen, "BitZilla", id+3);
+ else if (memcmp (id+1, "BM", 2) == 0) four_digits (buf, buflen, "BitMagnet", id+3);
+ else if (memcmp (id+1, "BP", 2) == 0) four_digits (buf, buflen, "BitTorrent Pro (Azureus + Spyware)", id+3);
+ else if (memcmp (id+1, "BX", 2) == 0) four_digits (buf, buflen, "BittorrentX", id+3);
+ else if (memcmp (id+1, "bk", 2) == 0) four_digits (buf, buflen, "BitKitten (libtorrent)", id+3);
+ else if (memcmp (id+1, "BS", 2) == 0) four_digits (buf, buflen, "BTSlave", id+3);
+ else if (memcmp (id+1, "BW", 2) == 0) four_digits (buf, buflen, "BitWombat", id+3);
+ else if (memcmp (id+1, "BX", 2) == 0) four_digits (buf, buflen, "BittorrentX", id+3);
+ else if (memcmp (id+1, "EB", 2) == 0) four_digits (buf, buflen, "EBit", id+3);
+ else if (memcmp (id+1, "DE", 2) == 0) four_digits (buf, buflen, "Deluge", id+3);
+ else if (memcmp (id+1, "DP", 2) == 0) four_digits (buf, buflen, "Propogate Data Client", id+3);
+ else if (memcmp (id+1, "FC", 2) == 0) four_digits (buf, buflen, "FileCroc", id+3);
+ else if (memcmp (id+1, "FT", 2) == 0) four_digits (buf, buflen, "FoxTorrent/RedSwoosh", id+3);
+ else if (memcmp (id+1, "GR", 2) == 0) four_digits (buf, buflen, "GetRight", id+3);
+ else if (memcmp (id+1, "GS", 2) == 0) four_digits (buf, buflen, "GSTorrent", id+3);
+ else if (memcmp (id+1, "HK", 2) == 0) four_digits (buf, buflen, "Hekate", id+3);
+ else if (memcmp (id+1, "HN", 2) == 0) four_digits (buf, buflen, "Hydranode", id+3);
+ else if (memcmp (id+1, "KG", 2) == 0) four_digits (buf, buflen, "KGet", id+3);
+ else if (memcmp (id+1, "LC", 2) == 0) four_digits (buf, buflen, "LeechCraft", id+3);
+ else if (memcmp (id+1, "LH", 2) == 0) four_digits (buf, buflen, "LH-ABC", id+3);
+ else if (memcmp (id+1, "NX", 2) == 0) four_digits (buf, buflen, "Net Transport", id+3);
+ else if (memcmp (id+1, "MK", 2) == 0) four_digits (buf, buflen, "Meerkat", id+3);
+ else if (memcmp (id+1, "MO", 2) == 0) four_digits (buf, buflen, "MonoTorrent", id+3);
+ else if (memcmp (id+1, "MR", 2) == 0) four_digits (buf, buflen, "Miro", id+3);
+ else if (memcmp (id+1, "MT", 2) == 0) four_digits (buf, buflen, "Moonlight", id+3);
+ else if (memcmp (id+1, "OS", 2) == 0) four_digits (buf, buflen, "OneSwarm", id+3);
+ else if (memcmp (id+1, "OT", 2) == 0) four_digits (buf, buflen, "OmegaTorrent", id+3);
+ else if (memcmp (id+1, "PD", 2) == 0) four_digits (buf, buflen, "Pando", id+3);
+ else if (memcmp (id+1, "QD", 2) == 0) four_digits (buf, buflen, "QQDownload", id+3);
+ else if (memcmp (id+1, "RS", 2) == 0) four_digits (buf, buflen, "Rufus", id+3);
+ else if (memcmp (id+1, "RT", 2) == 0) four_digits (buf, buflen, "Retriever", id+3);
+ else if (memcmp (id+1, "RZ", 2) == 0) four_digits (buf, buflen, "RezTorrent", id+3);
+ else if (memcmp (id+1, "SD", 2) == 0) four_digits (buf, buflen, "Thunder", id+3);
+ else if (memcmp (id+1, "SM", 2) == 0) four_digits (buf, buflen, "SoMud", id+3);
+ else if (memcmp (id+1, "SS", 2) == 0) four_digits (buf, buflen, "SwarmScope", id+3);
+ else if (memcmp (id+1, "ST", 2) == 0) four_digits (buf, buflen, "SymTorrent", id+3);
+ else if (memcmp (id+1, "SZ", 2) == 0) four_digits (buf, buflen, "Shareaza", id+3);
+ else if (memcmp (id+1, "S~", 2) == 0) four_digits (buf, buflen, "Shareaza", id+3);
+ else if (memcmp (id+1, "st", 2) == 0) four_digits (buf, buflen, "SharkTorrent", id+3);
+ else if (memcmp (id+1, "TN", 2) == 0) four_digits (buf, buflen, "Torrent .NET", id+3);
+ else if (memcmp (id+1, "TS", 2) == 0) four_digits (buf, buflen, "TorrentStorm", id+3);
+ else if (memcmp (id+1, "TT", 2) == 0) four_digits (buf, buflen, "TuoTu", id+3);
+ else if (memcmp (id+1, "UL", 2) == 0) four_digits (buf, buflen, "uLeecher!", id+3);
+ else if (memcmp (id+1, "VG", 2) == 0) four_digits (buf, buflen, "Vagaa", id+3);
+ else if (memcmp (id+1, "WT", 2) == 0) four_digits (buf, buflen, "BitLet", id+3);
+ else if (memcmp (id+1, "WY", 2) == 0) four_digits (buf, buflen, "FireTorrent", id+3);
+ else if (memcmp (id+1, "XL", 2) == 0) four_digits (buf, buflen, "Xunlei", id+3);
+ else if (memcmp (id+1, "XS", 2) == 0) four_digits (buf, buflen, "XSwifter", id+3);
+ else if (memcmp (id+1, "XT", 2) == 0) four_digits (buf, buflen, "XanTorrent", id+3);
+ else if (memcmp (id+1, "XX", 2) == 0) four_digits (buf, buflen, "Xtorrent", id+3);
+ else if (memcmp (id+1, "ZT", 2) == 0) four_digits (buf, buflen, "Zip Torrent", id+3);
+ else if (memcmp (id+1, "ZO", 2) == 0) four_digits (buf, buflen, "Zona", id+3);
+
+ else if (memcmp (id+1, "AG", 2) == 0) three_digits (buf, buflen, "Ares", id+3);
+ else if (memcmp (id+1, "A~", 2) == 0) three_digits (buf, buflen, "Ares", id+3);
+ else if (memcmp (id+1, "ES", 2) == 0) three_digits (buf, buflen, "Electric Sheep", id+3);
+ else if (memcmp (id+1, "HL", 2) == 0) three_digits (buf, buflen, "Halite", id+3);
+ else if (memcmp (id+1, "LT", 2) == 0) three_digits (buf, buflen, "libtorrent (Rasterbar)", id+3);
+ else if (memcmp (id+1, "lt", 2) == 0) three_digits (buf, buflen, "libTorrent (Rakshasa)", id+3);
+ else if (memcmp (id+1, "MP", 2) == 0) three_digits (buf, buflen, "MooPolice", id+3);
+ else if (memcmp (id+1, "pb", 2) == 0) three_digits (buf, buflen, "pbTorrent", id+3);
+ else if (memcmp (id+1, "TT", 2) == 0) three_digits (buf, buflen, "TuoTu", id+3);
+ else if (memcmp (id+1, "qB", 2) == 0) three_digits (buf, buflen, "qBittorrent", id+3);
+
+ else if (memcmp (id+1, "AX", 2) == 0) two_major_two_minor (buf, buflen, "BitPump", id+3);
+ else if (memcmp (id+1, "BC", 2) == 0) two_major_two_minor (buf, buflen, "BitComet", id+3);
+ else if (memcmp (id+1, "CD", 2) == 0) two_major_two_minor (buf, buflen, "Enhanced CTorrent", id+3);
+ else if (memcmp (id+1, "LP", 2) == 0) two_major_two_minor (buf, buflen, "Lphant", id+3);
+
+ else if (memcmp (id+1, "BF", 2) == 0) no_version (buf, buflen, "BitFlu");
+ else if (memcmp (id+1, "LW", 2) == 0) no_version (buf, buflen, "LimeWire");
+
+ else if (memcmp (id+1, "BB", 2) == 0)
{
tr_snprintf (buf, buflen, "BitBuddy %c.%c%c%c", id[3], id[4], id[5], id[6]);
}
- else if (!memcmp (id+1, "BR", 2))
+ else if (memcmp (id+1, "BR", 2) == 0)
{
tr_snprintf (buf, buflen, "BitRocket %c.%c (%c%c)", id[3], id[4], id[5], id[6]);
}
- else if (!memcmp (id+1, "CT", 2))
+ else if (memcmp (id+1, "CT", 2) == 0)
{
tr_snprintf (buf, buflen, "CTorrent %d.%d.%02d", charint (id[3]), charint (id[4]), strint (id+5,2));
}
- else if (!memcmp (id+1, "XC", 2) || !memcmp (id+1, "XX", 2))
+ else if (memcmp (id+1, "XC", 2) == 0 || memcmp (id+1, "XX", 2) == 0)
{
tr_snprintf (buf, buflen, "Xtorrent %d.%d (%d)", charint (id[3]), charint (id[4]), strint (id+5,2));
}
- else if (!memcmp (id+1, "BOW", 3))
+ else if (memcmp (id+1, "BOW", 3) == 0)
{
- if (!memcmp (&id[4], "A0B", 3)) tr_snprintf (buf, buflen, "Bits on Wheels 1.0.5");
- else if (!memcmp (&id[4], "A0C", 3)) tr_snprintf (buf, buflen, "Bits on Wheels 1.0.6");
+ if (memcmp (&id[4], "A0B", 3) == 0) tr_snprintf (buf, buflen, "Bits on Wheels 1.0.5");
+ else if (memcmp (&id[4], "A0C", 3) == 0) tr_snprintf (buf, buflen, "Bits on Wheels 1.0.6");
else tr_snprintf (buf, buflen, "Bits on Wheels %c.%c.%c", id[4], id[5], id[5]);
}
- else if (!memcmp (id+1, "MG", 2))
+ else if (memcmp (id+1, "MG", 2) == 0)
{
tr_snprintf (buf, buflen, "MediaGet %d.%02d", charint (id[3]), charint (id[4]));
}
/* uTorrent will replace the trailing dash with an extra digit for longer version numbers */
if (id[0] == '-')
{
- if (!memcmp (id+1, "UT", 2))
+ if (memcmp (id+1, "UT", 2) == 0)
{
tr_snprintf (buf, buflen, "\xc2\xb5Torrent %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,2), getMnemonicEnd (id[7]));
}
- else if (!memcmp (id+1, "UM", 2))
+ else if (memcmp (id+1, "UM", 2) == 0)
{
tr_snprintf (buf, buflen, "\xc2\xb5Torrent Mac %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,2), getMnemonicEnd (id[7]));
}
- else if (!memcmp (id+1, "UE", 2))
+ else if (memcmp (id+1, "UE", 2) == 0)
{
tr_snprintf (buf, buflen, "\xc2\xb5Torrent Embedded %d.%d.%d%s",
strint (id+3,1), strint (id+4,1), strint (id+5,2), getMnemonicEnd (id[7]));
return buf;
/* Clients with no version */
- if (!memcmp (id, "AZ2500BT", 8)) no_version (buf, buflen, "BitTyrant (Azureus Mod)");
- else if (!memcmp (id, "LIME", 4)) no_version (buf, buflen, "Limewire");
- else if (!memcmp (id, "martini", 7)) no_version (buf, buflen, "Martini Man");
- else if (!memcmp (id, "Pando", 5)) no_version (buf, buflen, "Pando");
- else if (!memcmp (id, "a00---0", 7)) no_version (buf, buflen, "Swarmy");
- else if (!memcmp (id, "a02---0", 7)) no_version (buf, buflen, "Swarmy");
- else if (!memcmp (id, "-G3", 3)) no_version (buf, buflen, "G3 Torrent");
- else if (!memcmp (id, "10-------", 9)) no_version (buf, buflen, "JVtorrent");
- else if (!memcmp (id, "346-", 4)) no_version (buf, buflen, "TorrentTopia");
- else if (!memcmp (id, "eX", 2)) no_version (buf, buflen, "eXeem");
- else if (!memcmp (id, "aria2-", 6)) no_version (buf, buflen, "aria2");
- else if (!memcmp (id, "-WT-", 4)) no_version (buf, buflen, "BitLet");
- else if (!memcmp (id, "-FG", 3)) two_major_two_minor (buf, buflen, "FlashGet", id+3);
+ if (memcmp (id, "AZ2500BT", 8) == 0) no_version (buf, buflen, "BitTyrant (Azureus Mod)");
+ else if (memcmp (id, "LIME", 4) == 0) no_version (buf, buflen, "Limewire");
+ else if (memcmp (id, "martini", 7) == 0) no_version (buf, buflen, "Martini Man");
+ else if (memcmp (id, "Pando", 5) == 0) no_version (buf, buflen, "Pando");
+ else if (memcmp (id, "a00---0", 7) == 0) no_version (buf, buflen, "Swarmy");
+ else if (memcmp (id, "a02---0", 7) == 0) no_version (buf, buflen, "Swarmy");
+ else if (memcmp (id, "-G3", 3) == 0) no_version (buf, buflen, "G3 Torrent");
+ else if (memcmp (id, "10-------", 9) == 0) no_version (buf, buflen, "JVtorrent");
+ else if (memcmp (id, "346-", 4) == 0) no_version (buf, buflen, "TorrentTopia");
+ else if (memcmp (id, "eX", 2) == 0) no_version (buf, buflen, "eXeem");
+ else if (memcmp (id, "aria2-", 6) == 0) no_version (buf, buflen, "aria2");
+ else if (memcmp (id, "-WT-", 4) == 0) no_version (buf, buflen, "BitLet");
+ else if (memcmp (id, "-FG", 3) == 0) two_major_two_minor (buf, buflen, "FlashGet", id+3);
/* Everything else */
- else if (!memcmp (id, "S3", 2) && id[2] == '-' && id[4] == '-' && id[6] == '-')
+ else if (memcmp (id, "S3", 2) == 0 && id[2] == '-' && id[4] == '-' && id[6] == '-')
{
tr_snprintf (buf, buflen, "Amazon S3 %c.%c.%c", id[3], id[5], id[7]);
}
- else if (!memcmp (id, "OP", 2))
+ else if (memcmp (id, "OP", 2) == 0)
{
tr_snprintf (buf, buflen, "Opera (Build %c%c%c%c)", id[2], id[3], id[4], id[5]);
}
- else if (!memcmp (id, "-ML", 3))
+ else if (memcmp (id, "-ML", 3) == 0)
{
tr_snprintf (buf, buflen, "MLDonkey %c%c%c%c%c", id[3], id[4], id[5], id[6], id[7]);
}
- else if (!memcmp (id, "DNA", 3))
+ else if (memcmp (id, "DNA", 3) == 0)
{
tr_snprintf (buf, buflen, "BitTorrent DNA %d.%d.%d", strint (id+3,2),
strint (id+5,2),
strint (id+7,2));
}
- else if (!memcmp (id, "Plus", 4))
+ else if (memcmp (id, "Plus", 4) == 0)
{
tr_snprintf (buf, buflen, "Plus! v2 %c.%c%c", id[4], id[5], id[6]);
}
- else if (!memcmp (id, "XBT", 3))
+ else if (memcmp (id, "XBT", 3) == 0)
{
tr_snprintf (buf, buflen, "XBT Client %c.%c.%c%s", id[3], id[4], id[5], getMnemonicEnd (id[6]));
}
- else if (!memcmp (id, "Mbrst", 5))
+ else if (memcmp (id, "Mbrst", 5) == 0)
{
tr_snprintf (buf, buflen, "burst! %c.%c.%c", id[5], id[7], id[9]);
}
- else if (!memcmp (id, "btpd", 4))
+ else if (memcmp (id, "btpd", 4) == 0)
{
tr_snprintf (buf, buflen, "BT Protocol Daemon %c%c%c", id[5], id[6], id[7]);
}
- else if (!memcmp (id, "BLZ", 3))
+ else if (memcmp (id, "BLZ", 3) == 0)
{
tr_snprintf (buf, buflen, "Blizzard Downloader %d.%d", id[3]+1, id[4]);
}
- else if (!memcmp (id, "-SP", 3))
+ else if (memcmp (id, "-SP", 3) == 0)
{
three_digits (buf, buflen, "BitSpirit", id+3);
}
- else if ('\0' == id[0] && !memcmp (id+2, "BS", 2))
+ else if ('\0' == id[0] && memcmp (id+2, "BS", 2) == 0)
{
tr_snprintf (buf, buflen, "BitSpirit %u", (id[1] == 0 ? 1 : id[1]));
}
- else if (!memcmp (id, "QVOD", 4))
+ else if (memcmp (id, "QVOD", 4) == 0)
{
four_digits (buf, buflen, "QVOD", id+4);
}
- else if (!memcmp (id, "-NE", 3))
+ else if (memcmp (id, "-NE", 3) == 0)
{
four_digits (buf, buflen, "BT Next Evolution", id+3);
}
- else if (!memcmp (id, "TIX", 3))
+ else if (memcmp (id, "TIX", 3) == 0)
{
two_major_two_minor (buf, buflen, "Tixati", id+3);
}
/* confirm the protocol */
tr_peerIoReadBytes (handshake->io, inbuf, name, HANDSHAKE_NAME_LEN);
- if (memcmp (name, HANDSHAKE_NAME, HANDSHAKE_NAME_LEN))
+ if (memcmp (name, HANDSHAKE_NAME, HANDSHAKE_NAME_LEN) != 0)
return HANDSHAKE_ENCRYPTION_WRONG;
/* read the reserved bytes */
tr_peerIoReadBytes (handshake->io, inbuf, hash, sizeof (hash));
assert (tr_peerIoHasTorrentHash (handshake->io));
if (!tr_torrentExists (handshake->session, hash)
- || memcmp (hash, tr_peerIoGetTorrentHash (handshake->io), SHA_DIGEST_LENGTH))
+ || memcmp (hash, tr_peerIoGetTorrentHash (handshake->io), SHA_DIGEST_LENGTH) != 0)
{
dbgmsg (handshake, "peer returned the wrong hash. wtf?");
return HANDSHAKE_BAD_TORRENT;
dbgmsg (handshake, "peer-id is [%*.*s]", PEER_ID_LEN, PEER_ID_LEN, peer_id);
tor = tr_torrentFindFromHash (handshake->session, hash);
- if (!memcmp (peer_id, tr_torrentGetPeerId(tor), PEER_ID_LEN))
+ if (memcmp (peer_id, tr_torrentGetPeerId(tor), PEER_ID_LEN) == 0)
{
dbgmsg (handshake, "streuth! we've connected to ourselves.");
return HANDSHAKE_PEER_IS_SELF;
memcpy (tmp, evbuffer_pullup (inbuf, key_len), key_len);
tr_cryptoDecryptInit (handshake->crypto);
tr_cryptoDecrypt (handshake->crypto, key_len, tmp, tmp);
- if (!memcmp (tmp, key, key_len))
+ if (memcmp (tmp, key, key_len) == 0)
break;
evbuffer_drain (inbuf, 1);
assert (pstrlen == 19);
tr_peerIoReadBytes (handshake->io, inbuf, pstr, pstrlen);
pstr[pstrlen] = '\0';
- if (memcmp (pstr, "BitTorrent protocol", 19))
+ if (memcmp (pstr, "BitTorrent protocol", 19) != 0)
return tr_handshakeDone (handshake, false);
/* reserved bytes */
{
assert (tr_peerIoHasTorrentHash (handshake->io));
- if (memcmp (hash, tr_peerIoGetTorrentHash (handshake->io), SHA_DIGEST_LENGTH))
+ if (memcmp (hash, tr_peerIoGetTorrentHash (handshake->io), SHA_DIGEST_LENGTH) != 0)
{
dbgmsg (handshake, "peer returned the wrong hash. wtf?");
return tr_handshakeDone (handshake, false);
/* if we've somehow connected to ourselves, don't keep the connection */
tor = tr_torrentFindFromHash (handshake->session, tr_peerIoGetTorrentHash (handshake->io));
- connected_to_self = (tor != NULL) && !memcmp (peer_id, tr_torrentGetPeerId(tor), PEER_ID_LEN);
+ connected_to_self = (tor != NULL) && memcmp (peer_id, tr_torrentGetPeerId(tor), PEER_ID_LEN) == 0;
return tr_handshakeDone (handshake, !connected_to_self);
}
uint8_t hash[SHA_DIGEST_LENGTH];
return recalculateHash (tor, piece, hash)
- && !memcmp (hash, tor->info.pieces[piece].hash, SHA_DIGEST_LENGTH);
+ && memcmp (hash, tor->info.pieces[piece].hash, SHA_DIGEST_LENGTH) == 0;
}
bool
check_streq_impl (const char * file, int line, const char * expected, const char * actual)
{
- const bool pass = !tr_strcmp0 (expected, actual);
+ const bool pass = tr_strcmp0 (expected, actual) == 0;
if (should_print (pass)) {
if (pass)
uint8_t sha1[SHA_DIGEST_LENGTH];
tr_magnet_info * info = NULL;
- if ((uri != NULL) && !memcmp (uri, "magnet:?", 8))
+ if (uri != NULL && memcmp (uri, "magnet:?", 8) == 0)
{
const char * walk;
else
vallen = strlen (val);
- if ((keylen==2) && !memcmp (key, "xt", 2) && val && !memcmp (val, "urn:btih:", 9))
+ if (keylen == 2 && memcmp (key, "xt", 2) == 0 && val != NULL && memcmp (val, "urn:btih:", 9) == 0)
{
const char * hash = val + 9;
const size_t hashlen = vallen - 9;
}
}
- if ((vallen > 0) && (keylen==2) && !memcmp (key, "dn", 2))
+ if (vallen > 0 && keylen == 2 && memcmp (key, "dn", 2) == 0)
displayName = tr_http_unescape (val, vallen);
if ((vallen > 0) && (trCount < MAX_TRACKERS))
{
int i;
- if ((keylen==2) && !memcmp (key, "tr", 2))
+ if (keylen == 2 && memcmp (key, "tr", 2) == 0)
tr[trCount++] = tr_http_unescape (val, vallen);
else if ((sscanf (key, "tr.%d=", &i) == 1) && (i >= 0)) /* ticket #3341 and #5134 */
tr[trCount++] = tr_http_unescape (val, vallen);
}
- if ((vallen > 0) && (keylen==2) && !memcmp (key, "ws", 2) && (wsCount < MAX_WEBSEEDS))
+ if (vallen > 0 && keylen == 2 && memcmp (key, "ws", 2) == 0 && wsCount < MAX_WEBSEEDS)
ws[wsCount++] = tr_http_unescape (val, vallen);
walk = next != NULL ? next + 1 : NULL;
* it will be taken as a sign that that tracker doesn't support
* the scrape convention. If it does, substitute 'scrape' for
* 'announce' to find the scrape page. */
- if (((s = strrchr (announce, '/'))) && !strncmp (++s, "announce", 8))
+ if (((s = strrchr (announce, '/')) != NULL) && strncmp (++s, "announce", 8) == 0)
{
const char * prefix = announce;
const size_t prefix_len = s - announce;
assert (walk - scrape == (int)alloc_len);
}
/* Some torrents with UDP annouce URLs don't have /announce. */
- else if (!strncmp (announce, "udp:", 4))
+ else if (strncmp (announce, "udp:", 4) == 0)
{
scrape = tr_strdup (announce);
}
return NULL;
while (getmntent(fp, &mnt))
- if (!tr_strcmp0 (path, mnt.mnt_mountp))
+ if (tr_strcmp0 (path, mnt.mnt_mountp) == 0)
break;
fclose(fp);
return mnt.mnt_special;
return NULL;
while ((mnt = getmntent(fp)) != NULL)
- if (!tr_strcmp0 (path, mnt->mnt_dir))
+ if (tr_strcmp0 (path, mnt->mnt_dir) == 0)
break;
endmntent(fp);
return NULL;
for (i=0; i<n; i++)
- if (!tr_strcmp0 (path, mnt[i].f_mntonname))
+ if (tr_strcmp0 (path, mnt[i].f_mntonname) == 0)
break;
return (i < n) ? mnt[i].f_mntfromname : NULL;
if (fp == NULL)
return NULL;
while (getmntent(fp, &mnt))
- if (!tr_strcmp0 (device, mnt.mnt_mountp))
+ if (tr_strcmp0 (device, mnt.mnt_mountp) == 0)
break;
fclose(fp);
return mnt.mnt_fstype;
return NULL;
while ((mnt = getmntent (fp)) != NULL)
- if (!tr_strcmp0 (device, mnt->mnt_fsname))
+ if (tr_strcmp0 (device, mnt->mnt_fsname) == 0)
break;
endmntent(fp);
return NULL;
for (i=0; i<n; i++)
- if (!tr_strcmp0 (device, mnt[i].f_mntfromname))
+ if (tr_strcmp0 (device, mnt[i].f_mntfromname) == 0)
break;
return (i < n) ? mnt[i].f_fstypename : NULL;
{
*end = '\0';
- if (!memcmp (value, "$HOME/", 6))
+ if (memcmp (value, "$HOME/", 6) == 0)
user_dir = tr_buildPath (getHomeDir (), value+6, NULL);
- else if (!strcmp (value, "$HOME"))
+ else if (strcmp (value, "$HOME") == 0)
user_dir = tr_strdup (getHomeDir ());
else
user_dir = tr_strdup (value);
ret = memcmp (a->str, b->str, MIN (a->len, b->len));
- if (!ret && (a->len != b->len))
+ if (ret == 0 && a->len != b->len)
ret = a->len < b->len ? -1 : 1;
return ret;
contents = tr_loadFile (path, &contents_len, NULL);
success = contents != NULL
- && (str_len == contents_len)
- && (!memcmp (contents, str, contents_len));
+ && str_len == contents_len
+ && memcmp (contents, str, contents_len) == 0;
tr_free (contents);
tr_free (path);
{
ret = TR_FR_NAME;
- if (tr_strcmp0 (tr_torrentName(tor), name))
+ if (tr_strcmp0 (tr_torrentName(tor), name) != 0)
{
tr_free (tor->info.name);
tor->info.name = tr_strdup (name);
if (!tr_variantGetRaw (b, &buf, &buflen))
err = "Invalid value for \"blocks\"";
- else if ((buflen == 3) && !memcmp (buf, "all", 3))
+ else if (buflen == 3 && memcmp (buf, "all", 3) == 0)
tr_bitfieldSetHasAll (&blocks);
- else if ((buflen == 4) && !memcmp (buf, "none", 4))
+ else if (buflen == 4 && memcmp (buf, "none", 4) == 0)
tr_bitfieldSetHasNone (&blocks);
else
tr_bitfieldSetRaw (&blocks, buf, buflen, true);
}
else if (tr_variantDictFindStr (prog, TR_KEY_have, &str, NULL))
{
- if (!strcmp (str, "all"))
+ if (strcmp (str, "all") == 0)
tr_bitfieldSetHasAll (&blocks);
else
err = "Invalid value for HAVE";
const struct tr_mimepart * p = tr_ptrArrayNth (&parts, i);
const char * ours = get_current_session_id (server);
const size_t ourlen = strlen (ours);
- hasSessionId = ourlen<=p->body_len && !memcmp (p->body, ours, ourlen);
+ hasSessionId = ourlen <= p->body_len && memcmp (p->body, ours, ourlen) == 0;
}
if (!hasSessionId)
bool have_source = false;
char * body = p->body;
- if (body_len >= 2 && !memcmp (&body[body_len - 2], "\r\n", 2))
+ if (body_len >= 2 && memcmp (&body[body_len - 2], "\r\n", 2) == 0)
body_len -= 2;
tr_variantInitDict (&top, 2);
const char * dot = strrchr (path, '.');
for (i = 0; dot && i < TR_N_ELEMENTS (types); ++i)
- if (!strcmp (dot + 1, types[i].suffix))
+ if (strcmp (dot + 1, types[i].suffix) == 0)
return types[i].mime_type;
return "application/octet-stream";
{
const char * ours = get_current_session_id (server);
const char * theirs = evhttp_find_header (req->input_headers, TR_RPC_SESSION_ID_HEADER);
- const bool success = theirs && !strcmp (theirs, ours);
+ const bool success = theirs != NULL && strcmp (theirs, ours) == 0;
return success;
}
"<p>If you're still using ACLs, use a whitelist instead. See the transmission-daemon manpage for details.</p>");
}
else if (server->isPasswordEnabled
- && (!pass || !user || strcmp (server->username, user)
+ && (pass == NULL || user == NULL || strcmp (server->username, user) != 0
|| !tr_ssha1_matches (server->password,
pass)))
{
"Basic realm=\"" MY_REALM "\"");
send_simple_response (req, 401, "Unauthorized User");
}
- else if (strncmp (req->uri, server->url, strlen (server->url)))
+ else if (strncmp (req->uri, server->url, strlen (server->url)) != 0)
{
char * location = tr_strdup_printf ("%sweb/", server->url);
evhttp_add_header (req->output_headers, "Location", location);
send_simple_response (req, HTTP_MOVEPERM, NULL);
tr_free (location);
}
- else if (!strncmp (req->uri + strlen (server->url), "web/", 4))
+ else if (strncmp (req->uri + strlen (server->url), "web/", 4) == 0)
{
handle_web_client (req, server);
}
- else if (!strcmp (req->uri + strlen (server->url), "upload"))
+ else if (strcmp (req->uri + strlen (server->url), "upload") == 0)
{
handle_upload (req, server);
}
tr_free (tmp);
}
#endif
- else if (!strncmp (req->uri + strlen (server->url), "rpc", 3))
+ else if (strncmp (req->uri + strlen (server->url), "rpc", 3) == 0)
{
handle_rpc (req, server);
}
}
else if (tr_variantDictFindStr (args, TR_KEY_ids, &str, NULL))
{
- if (!strcmp (str, "recently-active"))
+ if (strcmp (str, "recently-active") == 0)
{
tr_torrent * tor = NULL;
const time_t now = tr_time ();
assert (idle_data == NULL);
- if (tr_variantDictFindStr (args_in, TR_KEY_ids, &strVal, NULL) && !strcmp (strVal, "recently-active"))
+ if (tr_variantDictFindStr (args_in, TR_KEY_ids, &strVal, NULL) && strcmp (strVal, "recently-active") == 0)
{
int n = 0;
tr_variant * d;
for (i=0; i<n; ++i)
{
- if (!strcmp (t[i].announce, url))
+ if (strcmp (t[i].announce, url) == 0)
{
found = true;
if (filename == NULL)
return false;
- return !strncmp (filename, "ftp://", 6) ||
- !strncmp (filename, "http://", 7) ||
- !strncmp (filename, "https://", 8);
+ return strncmp (filename, "ftp://", 6) == 0 ||
+ strncmp (filename, "http://", 7) == 0 ||
+ strncmp (filename, "https://", 8) == 0;
}
static tr_file_index_t*
tr_ctorSetMetainfo (ctor, (uint8_t*)metainfo, len);
tr_free (metainfo);
}
- else if (!strncmp (fname, "magnet:?", 8))
+ else if (strncmp (fname, "magnet:?", 8) == 0)
{
tr_ctorSetMetainfoFromMagnetLink (ctor, fname);
}
if (tr_variantDictFindStr (args_in, TR_KEY_encryption, &str, NULL))
{
- if (!tr_strcmp0 (str, "required"))
+ if (tr_strcmp0 (str, "required") == 0)
tr_sessionSetEncryption (session, TR_ENCRYPTION_REQUIRED);
- else if (!tr_strcmp0 (str, "tolerated"))
+ else if (tr_strcmp0 (str, "tolerated") == 0)
tr_sessionSetEncryption (session, TR_CLEAR_PREFERRED);
else
tr_sessionSetEncryption (session, TR_ENCRYPTION_PREFERRED);
const int n = TR_N_ELEMENTS (methods);
for (i=0; i<n; ++i)
- if (!strcmp (str, methods[i].name))
+ if (strcmp (str, methods[i].name) == 0)
break;
if (i ==n)
if (delim)
{
char * key = tr_strndup (pch, (size_t) (delim - pch));
- int isArg = strcmp (key, "method") && strcmp (key, "tag");
+ bool isArg = strcmp (key, "method") != 0 && strcmp (key, "tag") != 0;
tr_variant * parent = isArg ? args : ⊤
tr_rpc_parse_list_str (tr_variantDictAdd (parent, tr_quark_new (key, (size_t) (delim - pch))),
tr_peerIdInit (peer_id);
check (strlen ((char*)peer_id) == PEER_ID_LEN);
- check (!memcmp (peer_id, PEERID_PREFIX, 8));
+ check (memcmp (peer_id, PEERID_PREFIX, 8) == 0);
for (j = 8; j < PEER_ID_LEN; ++j)
{
}
if (is_default_value && bindinfo)
- *is_default_value = !tr_strcmp0 (default_value, tr_address_to_string (&bindinfo->addr));
+ *is_default_value = tr_strcmp0 (default_value, tr_address_to_string (&bindinfo->addr)) == 0;
return bindinfo ? &bindinfo->addr : NULL;
}
{
int64_t free_space;
- if (!tr_strcmp0 (dir, tr_sessionGetDownloadDir (session)))
+ if (tr_strcmp0 (dir, tr_sessionGetDownloadDir (session)) == 0)
free_space = tr_device_info_get_free_space (session->downloadDir);
else
free_space = tr_getDirFreeSpace (dir);
const size_t slen = strlen (str);
const size_t elen = strlen (end);
- return slen >= elen && !memcmp (&str[slen - elen], end, elen);
+ return slen >= elen && memcmp (&str[slen - elen], end, elen) == 0;
}
static void
/* we've got a complete set of metainfo... see if it passes the checksum test */
dbgmsg (tor, "metainfo piece %d was the last one", piece);
tr_sha1 (sha1, m->metadata, m->metadata_size, NULL);
- if ((checksumPassed = !memcmp (sha1, tor->info.hash, SHA_DIGEST_LENGTH)))
+ if ((checksumPassed = memcmp (sha1, tor->info.hash, SHA_DIGEST_LENGTH) == 0))
{
/* checksum passed; now try to parse it as benc */
tr_variant infoDict;
while ((tor = tr_torrentNext (session, tor)))
if (*tor->info.hash == *torrentHash)
- if (!memcmp (tor->info.hash, torrentHash, SHA_DIGEST_LENGTH))
+ if (memcmp (tor->info.hash, torrentHash, SHA_DIGEST_LENGTH) == 0)
return tor;
return NULL;
tr_torrent * tor = NULL;
while ((tor = tr_torrentNext (session, tor)))
- if (!memcmp (tor->obfuscatedHash, obfuscatedTorrentHash, SHA_DIGEST_LENGTH))
+ if (memcmp (tor->obfuscatedHash, obfuscatedTorrentHash, SHA_DIGEST_LENGTH) == 0)
return tor;
return NULL;
{
assert (tr_isTorrent (tor));
- if (!path || !tor->downloadDir || strcmp (path, tor->downloadDir))
+ if (path == NULL || tor->downloadDir == NULL || strcmp (path, tor->downloadDir) != 0)
{
tr_free (tor->downloadDir);
tor->downloadDir = tr_strdup (path);
bool clear = true;
for (i=0; clear && i<trackerCount; ++i)
- if (!strcmp (trackers[i].announce, tor->errorTracker))
+ if (strcmp (trackers[i].announce, tor->errorTracker) == 0)
clear = false;
if (clear)
static const int file_count = sizeof (files) / sizeof (files[0]);
for (i=0; i<file_count; ++i)
- if (!strcmp (base, files[i]))
+ if (strcmp (base, files[i]) == 0)
return true;
#ifdef __APPLE__
/* check for resource forks. <http://support.apple.com/kb/TA20578> */
- if (!memcmp (base, "._", 2))
+ if (memcmp (base, "._", 2) == 0)
return true;
#endif
* it until now -- then rename it to match the one in the metadata */
if (tr_torrentFindFile2 (tor, fileIndex, &base, &sub, NULL))
{
- if (strcmp (sub, f->name))
+ if (strcmp (sub, f->name) != 0)
{
char * oldpath = tr_buildPath (base, sub, NULL);
char * newpath = tr_buildPath (base, f->name, NULL);
{
return (oldpath && *oldpath)
&& (newname && *newname)
- && (strcmp (newname, "."))
- && (strcmp (newname, ".."))
+ && (strcmp (newname, ".") != 0)
+ && (strcmp (newname, "..") != 0)
&& (strchr (newname, TR_PATH_DELIMITER) == NULL);
}
const char * name = tor->info.files[i].name;
const size_t len = strlen (name);
if ((len == oldpath_len || (len > oldpath_len && name[oldpath_len] == '/')) &&
- !memcmp (oldpath, name, oldpath_len))
+ memcmp (oldpath, name, oldpath_len) == 0)
indices[n++] = i;
}
tr_free (tmp);
}
- if (!strcmp (file->name, name))
+ if (strcmp (file->name, name) == 0)
{
tr_free (name);
}
if ((matchlen < len)
&& (str[0] == '-')
&& (str[1] == '-')
- && !strncmp (str+2, o->longName, len)
+ && strncmp (str+2, o->longName, len) == 0
&& (str[len + 2] == '\0' || (o->has_arg && str[len + 2] == '=')))
{
matchlen = len;
if ((matchlen < len)
&& (str[0] == '-')
- && !strncmp (str+1, o->shortName, len)
+ && strncmp (str+1, o->shortName, len) == 0
&& (str[len + 1] == '\0' || o->has_arg))
{
matchlen = len;
/* handle the builtin 'help' option */
for (i = 1; i < argc; ++i)
{
- if (!strcmp (argv[i], "-h") || !strcmp (argv[i], "--help"))
+ if (strcmp (argv[i], "-h") == 0 || strcmp (argv[i], "--help") == 0)
{
tr_getopt_usage (argv[0], usage, opts);
exit (0);
}
*out = '\0';
- return !in || strcmp (buf, in) ? buf : in;
+ return (in == NULL || strcmp (buf, in) != 0) ? buf : in;
}
/**
if (needlelen > haystacklen || !haystack || !needle)
return NULL;
for (i=0; i<=haystacklen-needlelen; ++i)
- if (!memcmp (haystack+i, needle, needlelen))
+ if (memcmp (haystack + i, needle, needlelen) == 0)
return haystack+i;
return NULL;
#endif
err = tr_bencParseStr (buf, buf+n, &end, &str, &len);
check_int_eq (0, err);
check_int_eq (4, len);
- check (!strncmp ((const char*)str, "boat", len));
+ check (strncmp ((const char*)str, "boat", len) == 0);
check (end == buf + 6);
str = NULL;
end = NULL;
err = tr_bencParseStr (buf, buf+n, &end, &str, &len);
check_int_eq (0, err);
check_int_eq (3, len);
- check (!strncmp ((const char*)str, "boa", len));
+ check (strncmp ((const char*)str, "boa", len) == 0);
check (end == buf + 5);
str = NULL;
end = NULL;
*setme = v->val.i!=0;
if (!success && tr_variantGetStr (v, &str, NULL))
- if ((success = (!strcmp (str,"true") || !strcmp (str,"false"))))
- *setme = !strcmp (str,"true");
+ if ((success = (strcmp (str,"true") == 0 || strcmp (str,"false") == 0)))
+ *setme = strcmp (str,"true") == 0;
return success;
}
uint8_t hash[SHA_DIGEST_LENGTH];
tr_sha1_final (sha, hash);
- hasPiece = !memcmp (hash, tor->info.pieces[pieceIndex].hash, SHA_DIGEST_LENGTH);
+ hasPiece = memcmp (hash, tor->info.pieces[pieceIndex].hash, SHA_DIGEST_LENGTH) == 0;
if (hasPiece || hadPiece)
{
int main( int argc, char ** argv )
{
- if( argc > 1 && !strncmp( argv[1], "-v", 2 ) )
+ if( argc > 1 && strncmp( argv[1], "-v", 2 ) == 0 )
{
char * env;
int debug = atoi( &argv[1][2] );
if (leftInPiece == 0)
{
const QByteArray result (myVerifyHash.result ());
- const bool matches = !memcmp (result.constData (),
- myInfo.pieces[myVerifyPieceIndex].hash,
- SHA_DIGEST_LENGTH);
+ const bool matches = memcmp (result.constData (),
+ myInfo.pieces[myVerifyPieceIndex].hash,
+ SHA_DIGEST_LENGTH) == 0;
myVerifyFlags[myVerifyPieceIndex] = matches;
myVerifyPiecePos = 0;
++myVerifyPieceIndex;
const char * val;
if (tr_variantGetStr (b, &val, NULL))
{
- if (!qstrcmp (val , "required"))
+ if (qstrcmp (val , "required") == 0)
myPrefs.set (i, 2);
- else if (!qstrcmp (val , "preferred"))
+ else if (qstrcmp (val , "preferred") == 0)
myPrefs.set (i, 1);
- else if (!qstrcmp (val , "tolerated"))
+ else if (qstrcmp (val , "tolerated") == 0)
myPrefs.set (i, 0);
}
continue;
tr_variant * announce_list;
bool changed = false;
- if (tr_variantDictFindStr (metainfo, TR_KEY_announce, &str, NULL) && !strcmp (str, url))
+ if (tr_variantDictFindStr (metainfo, TR_KEY_announce, &str, NULL) && strcmp (str, url) == 0)
{
printf ("\tRemoved \"%s\" from \"announce\"\n", str);
tr_variantDictRemove (metainfo, TR_KEY_announce);
int nodeIndex = 0;
while ((node = tr_variantListChild (tier, nodeIndex)))
{
- if (tr_variantGetStr (node, &str, NULL) && !strcmp (str, url))
+ if (tr_variantGetStr (node, &str, NULL) && strcmp (str, url) == 0)
{
printf ("\tRemoved \"%s\" from \"announce-list\" tier #%d\n", str, (tierIndex+1));
tr_variantListRemove (tier, nodeIndex);
const char * str;
int nodeCount = 0;
while ((node = tr_variantListChild (tier, nodeCount++)))
- if (tr_variantGetStr (node, &str, NULL) && !strcmp (str, url))
+ if (tr_variantGetStr (node, &str, NULL) && strcmp (str, url) == 0)
return true;
}
while (tr_variantDictChild (files, i++, &key, &val))
{
- if (!memcmp (inf->hash, tr_quark_get_string(key,NULL), SHA_DIGEST_LENGTH))
+ if (memcmp (inf->hash, tr_quark_get_string (key, NULL), SHA_DIGEST_LENGTH) == 0)
{
int64_t seeders = -1;
int64_t leechers = -1;
projects / transmission / commitdiff