]> granicus.if.org Git - procps-ng/commitdiff
pmap: Harden one_proc().
authorQualys Security Advisory <qsa@qualys.com>
Thu, 1 Jan 1970 00:00:00 +0000 (00:00 +0000)
committerCraig Small <csmall@enc.com.au>
Fri, 18 May 2018 21:32:22 +0000 (07:32 +1000)
Replace sprintf() with snprintf().

pmap.c

diff --git a/pmap.c b/pmap.c
index 9bc9c4c027416c55ac66b67841f6d0e62a22596d..48a4f199aedcf1fe392679e2b4d258de74d7d2c0 100644 (file)
--- a/pmap.c
+++ b/pmap.c
@@ -544,11 +544,11 @@ static int one_proc(proc_t * p)
        printf("%u:   %s\n", p->tgid, cmdbuf);
 
        if (x_option || X_option || c_option) {
-               sprintf(buf, "/proc/%u/smaps", p->tgid);
+               snprintf(buf, sizeof buf, "/proc/%u/smaps", p->tgid);
                if ((fp = fopen(buf, "r")) == NULL)
                        return 1;
        } else {
-               sprintf(buf, "/proc/%u/maps", p->tgid);
+               snprintf(buf, sizeof buf, "/proc/%u/maps", p->tgid);
                if ((fp = fopen(buf, "r")) == NULL)
                        return 1;
        }