Issue #25144: Ensures TargetDir is set before continuing with custom install.

diff --git a/Misc/NEWS b/Misc/NEWS
index e05e8e73fce10f7e202ce7be98675edf139d86c2..aeb38a1d77ca350fbf8ff7e3d262b6004c881dbc 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -275,6 +275,9 @@ Tools/Demos
 Windows
 -------
 
+- Issue #25144: Ensures TargetDir is set before continuing with custom
+  install.
+
 - Issue #27469: Adds a shell extension to the launcher so that drag and drop
   works correctly.
 

diff --git a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
index b7b2ecf39b38e1df88c1313f7a7889cb99c61028..6a67ee211ce76ae98f92f60c138fc70e81e830f0 100644 (file)
--- a/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
+++ b/Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
@@ -327,6 +327,9 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
         case ID_CUSTOM_INSTALL_BUTTON:
             SavePageSettings();
 
+            hr = EnsureTargetDir();
+            ExitOnFailure(hr, L"Failed to set TargetDir");
+
             hr = BalGetStringVariable(L"TargetDir", &targetDir);
             if (SUCCEEDED(hr)) {
                 // TODO: Check whether directory exists and contains another installation