]> granicus.if.org Git - libvpx/commitdiff
quantize test: lowbd functions do not pass in highbd
authorJohann <johannkoenig@google.com>
Wed, 19 Jul 2017 21:20:13 +0000 (14:20 -0700)
committerJohann <johannkoenig@google.com>
Thu, 20 Jul 2017 15:17:48 +0000 (08:17 -0700)
qcoeff output looks OK but dqcoeff is no good.

BUG=webm:1448

Change-Id: I07211db8a8b74f1f45fdd059852e2de0e5ee18fd

test/vp9_quantize_test.cc

index 44a4438b712e9265c3e183210e94a42fdb88edef..7cc71c65a36e12ee8aa138a5a7296bd02c774908 100644 (file)
@@ -353,11 +353,11 @@ using std::tr1::make_tuple;
 
 #if HAVE_SSE2
 #if CONFIG_VP9_HIGHBITDEPTH
+// TODO(johannkoenig): Fix vpx_quantize_b_sse2 in highbitdepth builds.
+// make_tuple(&vpx_quantize_b_sse2, &vpx_highbd_quantize_b_c, VPX_BITS_8),
 INSTANTIATE_TEST_CASE_P(
     SSE2, VP9QuantizeTest,
-    ::testing::Values(make_tuple(&vpx_quantize_b_sse2, &vpx_highbd_quantize_b_c,
-                                 VPX_BITS_8),
-                      make_tuple(&vpx_highbd_quantize_b_sse2,
+    ::testing::Values(make_tuple(&vpx_highbd_quantize_b_sse2,
                                  &vpx_highbd_quantize_b_c, VPX_BITS_8),
                       make_tuple(&vpx_highbd_quantize_b_sse2,
                                  &vpx_highbd_quantize_b_c, VPX_BITS_10),
@@ -392,8 +392,9 @@ INSTANTIATE_TEST_CASE_P(
                                  &vpx_quantize_b_32x32_c, VPX_BITS_8)));
 #endif  // HAVE_SSSE3 && ARCH_X86_64
 
-// TODO(johannkoenig): AVX optimizations do not yet pass the 32x32 test.
-#if HAVE_AVX && ARCH_X86_64
+// TODO(johannkoenig): AVX optimizations do not yet pass the 32x32 test or
+// highbitdepth configurations.
+#if HAVE_AVX && ARCH_X86_64 && !CONFIG_VP9_HIGHBITDEPTH
 INSTANTIATE_TEST_CASE_P(AVX, VP9QuantizeTest,
                         ::testing::Values(make_tuple(&vpx_quantize_b_avx,
                                                      &vpx_quantize_b_c,
@@ -403,5 +404,5 @@ INSTANTIATE_TEST_CASE_P(DISABLED_AVX, VP9Quantize32Test,
                         ::testing::Values(make_tuple(&vpx_quantize_b_32x32_avx,
                                                      &vpx_quantize_b_32x32_c,
                                                      VPX_BITS_8)));
-#endif  // HAVE_AVX && ARCH_X86_64
+#endif  // HAVE_AVX && ARCH_X86_64 && !CONFIG_VP9_HIGHBITDEPTH
 }  // namespace