]> granicus.if.org Git - procps-ng/commitdiff
top: always validate that p-core/e-core identification
authorJim Warner <james.warner@comcast.net>
Sat, 1 Oct 2022 05:00:00 +0000 (00:00 -0500)
committerCraig Small <csmall@dropbear.xyz>
Mon, 3 Oct 2022 23:57:34 +0000 (10:57 +1100)
Prior to this commit, when the '5' key was struck, top
would check for the presence of e-cores just one time.

That meant if a some cpu was brought online, and it in
turn exposed a new e-core after top has started, users
needed a top restart to activate the  new '5' feature.

So, now we'll check for any e-cores with each '5' key.

Signed-off-by: Jim Warner <james.warner@comcast.net>
src/top/top.c

index f3bef9a71606dbebdf385eb8ccdaaa4fdd4671d6..9ae7b1baeb456605e987af3d79954ff1059ec9c9 100644 (file)
@@ -5806,12 +5806,10 @@ static void keys_summary (int ch) {
          || ((w->rc.combine_cpus))))
             show_msg(N_txt(XTRA_modebad_txt));
          else {
-            static int scanned;
-            if (!scanned) {
-               for (; scanned < Cpu_cnt; scanned++)
-                  if (CPU_VAL(stat_COR_TYP, scanned) == E_CORE)
-                     break;
-            }
+            int scanned;
+            for (scanned = 0; scanned < Cpu_cnt; scanned++)
+               if (CPU_VAL(stat_COR_TYP, scanned) == E_CORE)
+                  break;
             if (scanned < Cpu_cnt) {
                w->rc.core_types += 1;
                if (w->rc.core_types > E_CORES_ONLY)