In debug mode, under CLI don't close stderr.

This is so that we can see any error reports.

# for extra paranoia, could limit this check to happen only after the script is
# finished running.

diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c
index b1b27f604991b5ab550695e74186c693dc17e063..9a4027ec9ab2955e91841350656b3382578e0c2a 100644 (file)
--- a/main/streams/plain_wrapper.c
+++ b/main/streams/plain_wrapper.c
@@ -428,7 +428,16 @@ static int php_stdiop_close(php_stream *stream, int close_handle TSRMLS_DC)
                                data->file = NULL;
                        }
                } else if (data->fd != -1) {
+#ifdef DEBUG
+                       if (data->fd == 2 && strcmp(sapi_module.name, "cli")) {
+                               /* don't close stderr in CLI in DEBUG mode, as we want to see any leaks */
+                               ret = 0;
+                       } else {
+                               ret = close(data->fd);
+                       }
+#else
                        ret = close(data->fd);
+#endif
                        data->fd = -1;
                } else {
                        return 0; /* everything should be closed already -> success */