]> granicus.if.org Git - python/commitdiff
Issue #18174: Fix leak of file descriptor in test_tempfile
authorVictor Stinner <victor.stinner@gmail.com>
Mon, 28 Jul 2014 23:13:39 +0000 (01:13 +0200)
committerVictor Stinner <victor.stinner@gmail.com>
Mon, 28 Jul 2014 23:13:39 +0000 (01:13 +0200)
Lib/test/test_tempfile.py

index b23c19fad61abc742eacf0fa47842aea4c61a50d..ec975f82a6f8a2ba10b3d95e2ca8fda951d5b956 100644 (file)
@@ -762,8 +762,10 @@ class TestNamedTemporaryFile(BaseTestCase):
     def test_no_leak_fd(self):
         # Issue #21058: don't leak file descriptor when io.open() fails
         closed = []
+        os_close = os.close
         def close(fd):
             closed.append(fd)
+            os_close(fd)
 
         with mock.patch('os.close', side_effect=close):
             with mock.patch('io.open', side_effect=ValueError):
@@ -1076,8 +1078,10 @@ if tempfile.NamedTemporaryFile is not tempfile.TemporaryFile:
         def test_no_leak_fd(self):
             # Issue #21058: don't leak file descriptor when io.open() fails
             closed = []
+            os_close = os.close
             def close(fd):
                 closed.append(fd)
+                os_close(fd)
 
             with mock.patch('os.close', side_effect=close):
                 with mock.patch('io.open', side_effect=ValueError):