patch 8.2.3304: popup window title with wide characters is truncated

Problem:    Popup window title with wide characters is truncated.
Solution:   Use vim_strsize() instead of MB_CHARLEN(). (Naruhiko Nishino,
            closes #8721)

diff --git a/src/popupwin.c b/src/popupwin.c
index 470bd70150d5b038c7d0beaa0ab094bc9aba1caa..d86c6c0ef114d28b44e90e003d86206f17d1c6d5 100644 (file)
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -3896,7 +3896,7 @@ update_popups(void (*win_update)(win_T *wp))
        title_wincol = wp->w_wincol + 1;
        if (wp->w_popup_title != NULL)
        {
-           title_len = (int)MB_CHARLEN(wp->w_popup_title);
+           title_len = vim_strsize(wp->w_popup_title);
 
            // truncate the title if too long
            if (title_len > total_width - 2)

diff --git a/src/testdir/dumps/Test_popupwin_multibytetitle.dump b/src/testdir/dumps/Test_popupwin_multibytetitle.dump
index e21c0cf2bbeb0e5a26d91fa1b31b7114f2b3ba14..95b08717ecd70a9ca0beeb4f0ec4bfd40555d9fc 100644 (file)
--- a/src/testdir/dumps/Test_popupwin_multibytetitle.dump
+++ b/src/testdir/dumps/Test_popupwin_multibytetitle.dump
@@ -1,7 +1,7 @@
 >1+0&#ffffff0| @73
 |2| @73
 |3| @73
-|4| @25|╔+0#0000001#ffd7ff255|▶|Ä|Ö|Ü|◀|═@12|╗| +0#0000000#ffffff0@27
+|4| @25|╔+0#0000001#ffd7ff255|▶|Ä|あ*&|い|う|え|お|◀+&|═@4|╗| +0#0000000#ffffff0@27
 |5| @25|║+0#0000001#ffd7ff255| |T+0&#e0e0e08|h|i|s| |i|s| |a| |l|i|n|e| @1| +0&#ffd7ff255|║| +0#0000000#ffffff0@27
 |6| @25|║+0#0000001#ffd7ff255| |a|n|d| |a|n|o|t|h|e|r| |l|i|n|e| |║| +0#0000000#ffffff0@27
 |7| @25|╚+0#0000001#ffd7ff255|═@17|╝| +0#0000000#ffffff0@27

diff --git a/src/testdir/test_popupwin.vim b/src/testdir/test_popupwin.vim
index 62e19fa5d241ec05986fcdc1472e87b84e4fdf75..83d632eeed5eee0183b8292a739258db295edfe7 100644 (file)
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -1817,7 +1817,7 @@ func Test_popup_title()
   call VerifyScreenDump(buf, 'Test_popupwin_longtitle_4', {})
 
   call term_sendkeys(buf, ":call popup_clear()\<CR>")
-  call term_sendkeys(buf, ":call popup_menu(['This is a line', 'and another line'], #{title: '▶ÄÖÜ◀', })\<CR>")
+  call term_sendkeys(buf, ":call popup_menu(['This is a line', 'and another line'], #{title: '▶Äあいうえお◀', })\<CR>")
   call VerifyScreenDump(buf, 'Test_popupwin_multibytetitle', {})
   call term_sendkeys(buf, "x")
 

diff --git a/src/version.c b/src/version.c
index fedc23befeed438d381d45d0d19805c9fb2da9cf..206234d9b9410226e74ae13f9f68d936441c7a5f 100644 (file)
--- a/src/version.c
+++ b/src/version.c
@@ -755,6 +755,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    3304,
 /**/
     3303,
 /**/