Tom Lane wrote:

> I see in your recent bytea-LIKE patch
>
>         if (datatype != BYTEAOID && pg_database_encoding_max_length()
> 1)
>             len = pg_mbcliplen((const unsigned char *) workstr, len,
len - 1);
>         else
>             len -= -1;
>
> Surely there's one too many minus signs in that last?

Joe Conway

diff --git a/src/backend/utils/adt/selfuncs.c b/src/backend/utils/adt/selfuncs.c
index c5a7b33b67b54521642d884ab8e1322ebdfd3744..693925b7ab5a2e4fa1934317633f8692208a9d37 100644 (file)
--- a/src/backend/utils/adt/selfuncs.c
+++ b/src/backend/utils/adt/selfuncs.c
@@ -15,7 +15,7 @@
  *
  *
  * IDENTIFICATION
- *       $Header: /cvsroot/pgsql/src/backend/utils/adt/selfuncs.c,v 1.117 2002/09/04 20:31:29 momjian Exp $
+ *       $Header: /cvsroot/pgsql/src/backend/utils/adt/selfuncs.c,v 1.118 2002/09/20 03:55:40 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -3376,7 +3376,7 @@ make_greater_string(const Const *str_const)
                if (datatype != BYTEAOID && pg_database_encoding_max_length() > 1)
                        len = pg_mbcliplen((const unsigned char *) workstr, len, len - 1);
                else
-                       len -= -1;
+                       len -= 1;
 
                if (datatype != BYTEAOID)
                        workstr[len] = '\0';