Sema::ActOnBlockReturnStmt(): Need to perform the UsualUnaryConversions on the return...

Sema::CheckReturnStackAddr(): Make sure we skip over implicit casts.
Added some more test cases...

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@56254 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp
index 00b469b7c05cff7d866e14029ba0c1f127659f73..f870e26b6a3aa92dce65f490cb047077fd557e5f 100644 (file)
--- a/lib/Sema/SemaChecking.cpp
+++ b/lib/Sema/SemaChecking.cpp
@@ -716,7 +716,12 @@ Sema::CheckReturnStackAddr(Expr *RetValExp, QualType lhsType,
       Diag(DR->getLocStart(), diag::warn_ret_stack_addr,
            DR->getDecl()->getIdentifier()->getName(),
            RetValExp->getSourceRange());
-           
+    
+    // Skip over implicit cast expressions when checking for block expressions.
+    if (ImplicitCastExpr *IcExpr = 
+          dyn_cast_or_null<ImplicitCastExpr>(RetValExp))
+      RetValExp = IcExpr->getSubExpr();
+
     if (BlockExpr *C = dyn_cast_or_null<BlockExpr>(RetValExp))
       Diag(C->getLocStart(), diag::err_ret_local_block,
            C->getSourceRange());

diff --git a/lib/Sema/SemaStmt.cpp b/lib/Sema/SemaStmt.cpp
index d7a812cb2a8522e85ac4b078c902003a2dd7859c..3cadd526a7755f619073ba538f4e2e3c94ae8b94 100644 (file)
--- a/lib/Sema/SemaStmt.cpp
+++ b/lib/Sema/SemaStmt.cpp
@@ -678,9 +678,10 @@ Sema::ActOnBlockReturnStmt(SourceLocation ReturnLoc, Expr *RetValExp) {
   // If this is the first return we've seen in the block, infer the type of
   // the block from it.
   if (CurBlock->ReturnType == 0) {
-    if (RetValExp)
+    if (RetValExp) {
+      UsualUnaryConversions(RetValExp);
       CurBlock->ReturnType = RetValExp->getType().getTypePtr();
-    else
+    } else
       CurBlock->ReturnType = Context.VoidTy.getTypePtr();
     return new ReturnStmt(ReturnLoc, RetValExp);
   }

diff --git a/test/Sema/block-return.c b/test/Sema/block-return.c
new file mode 100644 (file)
index 0000000..93511db
--- /dev/null
+++ b/test/Sema/block-return.c
@@ -0,0 +1,52 @@
+// RUN: clang -fsyntax-only %s -verify
+
+typedef void (^CL)(void);
+
+CL foo() {
+
+       short y;
+
+  short (^add1)(void) = ^{ return y+1; }; // expected-error {{incompatible block pointer types initializing 'int (^)(void)', expected 'short (^)(void)'}}
+
+       CL X = ^{ 
+    if (2) 
+      return; 
+    return 1;  // expected-error {{void block should not return a value}}
+  };
+       int (^Y) (void)  = ^{ 
+    if (3)
+      return 1;
+    else
+      return; // expected-error {{non-void block should return a value}}
+  };
+
+       char *(^Z)(void) = ^{ 
+    if (3)
+      return "";
+    else
+      return (char*)0;
+  };
+
+  double (^A)(void) = ^ { // expected-error {{incompatible block pointer types initializing 'float (^)(void)', expected 'double (^)(void)'}}
+    if (1)     
+      return (float)1.0; 
+    else
+      if (2)
+       return (double)2.0; // expected-error {{incompatible type returning 'double', expected 'float'}}
+    return 1; // expected-error {{incompatible type returning 'int', expected 'float'}}
+  };
+  
+  char *(^B)(void) = ^{ 
+    if (3)
+      return "";
+    else
+      return 2; // expected-error {{incompatible type returning 'int', expected 'char *'}}
+  };
+  return ^{ return 1; }; // expected-error {{incompatible block pointer types returning 'int (^)(void)', expected 'CL'}} expected-error {{returning block that lives on the local stack}}
+}
+
+typedef int (^CL2)(void);
+
+CL2 foo2() {
+  return ^{ return 1; }; // expected-error {{returning block that lives on the local stack}}
+}