]> granicus.if.org Git - python/commitdiff
[3.6] bpo-31320: No traceback to sys.stderr in test_ssl (GH-3360) (GH-3369)
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Wed, 6 Sep 2017 01:11:31 +0000 (18:11 -0700)
committerMariatta <Mariatta@users.noreply.github.com>
Wed, 6 Sep 2017 01:11:31 +0000 (18:11 -0700)
In case PROTOCOL_TLS_SERVER is used for both client context and server
context, the test thread dies with OSError. Catch OSError to avoid
traceback on sys.stderr

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 305e56c27afce605e5d2f71903a966cf0bb95038)

Lib/test/test_ssl.py
Misc/NEWS.d/next/Tests/2017-09-05-14-23-35.bpo-31320.JRDHx7.rst [new file with mode: 0644]

index 4c060ea1c1ec2878b39bf54d9b84383f5c466d4f..29d4b4083da0f90219ea7404a65fac3fcadcb248 100644 (file)
@@ -1843,11 +1843,14 @@ if _have_threads:
                         self.sock, server_side=True)
                     self.server.selected_npn_protocols.append(self.sslconn.selected_npn_protocol())
                     self.server.selected_alpn_protocols.append(self.sslconn.selected_alpn_protocol())
-                except (ssl.SSLError, ConnectionResetError) as e:
+                except (ssl.SSLError, ConnectionResetError, OSError) as e:
                     # We treat ConnectionResetError as though it were an
                     # SSLError - OpenSSL on Ubuntu abruptly closes the
                     # connection when asked to use an unsupported protocol.
                     #
+                    # OSError may occur with wrong protocols, e.g. both
+                    # sides use PROTOCOL_TLS_SERVER.
+                    #
                     # XXX Various errors can have happened here, for example
                     # a mismatching protocol version, an invalid certificate,
                     # or a low-level bug. This should be made more discriminating.
diff --git a/Misc/NEWS.d/next/Tests/2017-09-05-14-23-35.bpo-31320.JRDHx7.rst b/Misc/NEWS.d/next/Tests/2017-09-05-14-23-35.bpo-31320.JRDHx7.rst
new file mode 100644 (file)
index 0000000..8b7163d
--- /dev/null
@@ -0,0 +1 @@
+Silence traceback in test_ssl