Remove lint suppression from dmu.h and unnecessary dmu.h include in spa.h

Authored by: Dan Kimmel <dan.kimmel@delphix.com>
Reviewed by: Tom Caputi <tcaputi@datto.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Ported by: David Quigley <david.quigley@intel.com>
Issue #5078

diff --git a/include/sys/dmu.h b/include/sys/dmu.h
index 83919a624c5a97cd0f6eaf5032f10e8f100bd31f..4efab7c723cdaaaa2d54019c5b7252a7a382b970 100644 (file)
--- a/include/sys/dmu.h
+++ b/include/sys/dmu.h
@@ -562,12 +562,7 @@ typedef struct dmu_buf_user {
  * NOTE: This function should only be called once on a given dmu_buf_user_t.
  *       To allow enforcement of this, dbu must already be zeroed on entry.
  */
-#ifdef __lint
-/* Very ugly, but it beats issuing suppression directives in many Makefiles. */
-extern void
-dmu_buf_init_user(dmu_buf_user_t *dbu, dmu_buf_evict_func_t *evict_func,
-    dmu_buf_t **clear_on_evict_dbufp);
-#else /* __lint */
+/*ARGSUSED*/
 static inline void
 dmu_buf_init_user(dmu_buf_user_t *dbu, dmu_buf_evict_func_t *evict_func,
     dmu_buf_t **clear_on_evict_dbufp)
@@ -580,7 +575,6 @@ dmu_buf_init_user(dmu_buf_user_t *dbu, dmu_buf_evict_func_t *evict_func,
        dbu->dbu_clear_on_evict_dbufp = clear_on_evict_dbufp;
 #endif
 }
-#endif /* __lint */
 
 /*
  * Attach user data to a dbuf and mark it for normal (when the dbuf's

diff --git a/include/sys/spa.h b/include/sys/spa.h
index 320c5840278bcebf143e772ccd42baa4524fe4d3..0c71cca68d47bd2e32a48fcf717b4faa4dff18ab 100644 (file)
--- a/include/sys/spa.h
+++ b/include/sys/spa.h
@@ -36,6 +36,7 @@
 #include <sys/types.h>
 #include <sys/fs/zfs.h>
 #include <sys/spa_checksum.h>
+#include <sys/dmu.h>
 
 #ifdef __cplusplus
 extern "C" {
@@ -558,8 +559,6 @@ _NOTE(CONSTCOND) } while (0)
        ASSERT(len < size);                                             \
 }
 
-#include <sys/dmu.h>
-
 #define        BP_GET_BUFC_TYPE(bp)                                            \
        (((BP_GET_LEVEL(bp) > 0) || (DMU_OT_IS_METADATA(BP_GET_TYPE(bp)))) ? \
        ARC_BUFC_METADATA : ARC_BUFC_DATA)