]> granicus.if.org Git - icu/commitdiff
ICU-20652 Corrects calculation of byte sequence length to prevent buffer
authorNorbert Runge <nrunge@google.com>
Wed, 26 Jun 2019 20:41:59 +0000 (13:41 -0700)
committerAndy Heninger <andy.heninger@gmail.com>
Fri, 28 Jun 2019 00:11:40 +0000 (17:11 -0700)
overflow.

ICU-20652 Add parenthesis, improve readability.

icu4c/source/test/fuzzer/collator_compare_fuzzer.cpp

index b42b124e71e01ff9d8d98bb8c47d98c25def5f83..87b2ea98c2c7893635ad8bdb5979f8df33a9cd8e 100644 (file)
@@ -17,10 +17,10 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
     return 0;
 
   std::unique_ptr<char16_t> compbuff1(new char16_t[size/4]);
-  std::memcpy(compbuff1.get(), data, size/2);
+  std::memcpy(compbuff1.get(), data, (size/4)*2);
   data = data + size/2;
   std::unique_ptr<char16_t> compbuff2(new char16_t[size/4]);
-  std::memcpy(compbuff2.get(), data, size/2);
+  std::memcpy(compbuff2.get(), data, (size/4)*2);
 
   icu::LocalPointer<icu::Collator> fuzzCollator(
       icu::Collator::createInstance(icu::Locale::getUS(), status), status);