]> granicus.if.org Git - taglib/commitdiff
Fixed memory leak of FrameFactory singleton.
authorBirunthan Mohnathas <birunthan@mohanathas.com>
Mon, 12 Mar 2012 16:56:08 +0000 (18:56 +0200)
committerBirunthan Mohnathas <birunthan@mohanathas.com>
Mon, 12 Mar 2012 16:56:08 +0000 (18:56 +0200)
taglib/mpeg/id3v2/id3v2framefactory.cpp

index b6bc34a5c0281bd70d1846deff054dff72b98b7f..da9c801818d51792aaab9532bf8bad568ae7c7ef 100644 (file)
@@ -73,9 +73,8 @@ FrameFactory *FrameFactory::factory = 0;
 
 FrameFactory *FrameFactory::instance()
 {
-  if(!factory)
-    factory = new FrameFactory;
-  return factory;
+  static FrameFactory factory;
+  return &factory;
 }
 
 Frame *FrameFactory::createFrame(const ByteVector &data, bool synchSafeInts) const