]> granicus.if.org Git - php/commitdiff
This is not a problem here
authorXinchen Hui <laruence@gmail.com>
Sat, 28 May 2016 07:15:53 +0000 (15:15 +0800)
committerXinchen Hui <laruence@gmail.com>
Sat, 28 May 2016 07:17:14 +0000 (15:17 +0800)
if only for PHI placement, we may get rid of this `use` here.
But as the comment said, it is useful if we are going to do code generation

ext/opcache/Optimizer/zend_dfg.c

index abc9b3a1f5497a0be96b78fe6f50ffa83998cc4c..d5be92d317053dca376727b2dbfac93b2e57b3ba 100644 (file)
@@ -124,7 +124,8 @@ int zend_build_dfg(const zend_op_array *op_array, const zend_cfg *cfg, zend_dfg
                                        case ZEND_FETCH_OBJ_UNSET:
                                        case ZEND_VERIFY_RETURN_TYPE:
 op1_def:
-                                               // FIXME: include into "use" too ...?
+                                               /* `def` always come along with dtor or separation,
+                                                * thus the origin var info might be also `use`d in the feature(CG) */
                                                DFG_SET(use, set_size, j, var_num);
                                                DFG_SET(def, set_size, j, var_num);
                                                break;