]> granicus.if.org Git - handbrake/commitdiff
WinGui: Fix a large number of stylecop warnings.
authorsr55 <sr55.hb@outlook.com>
Tue, 19 Nov 2013 22:54:16 +0000 (22:54 +0000)
committersr55 <sr55.hb@outlook.com>
Tue, 19 Nov 2013 22:54:16 +0000 (22:54 +0000)
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@5900 b64f7644-9d1e-0410-96f1-a4d463321fa5

30 files changed:
win/CS/HandBrake.ApplicationServices/Factories/PlistPresetFactory.cs
win/CS/HandBrake.ApplicationServices/Model/EncodeTask.cs
win/CS/HandBrake.ApplicationServices/Model/Encoding/AudioTrack.cs
win/CS/HandBrake.ApplicationServices/Model/QueueTask.cs
win/CS/HandBrake.ApplicationServices/Services/Base/EncodeBase.cs
win/CS/HandBrake.ApplicationServices/Services/Encode.cs
win/CS/HandBrake.ApplicationServices/Services/LibScan.cs
win/CS/HandBrake.ApplicationServices/Services/PresetService.cs
win/CS/HandBrake.ApplicationServices/Services/ServerService.cs
win/CS/HandBrake.ApplicationServices/Settings.StyleCop
win/CS/HandBrake.ApplicationServices/Utilities/EnumHelper.cs
win/CS/HandBrake.ApplicationServices/Utilities/PList.cs
win/CS/HandBrake.ApplicationServices/Utilities/QueryGeneratorUtility.cs
win/CS/HandBrakeWPF/Commands/OpenOptionsScreenCommand.cs
win/CS/HandBrakeWPF/Converters/AdvancedVisibilityConverter.cs
win/CS/HandBrakeWPF/Converters/EnumComboConverter.cs
win/CS/HandBrakeWPF/Converters/Options/OptionsTabConverter.cs
win/CS/HandBrakeWPF/Services/PrePostActionService.cs
win/CS/HandBrakeWPF/Services/UserSettingService.cs
win/CS/HandBrakeWPF/ViewModels/AudioViewModel.cs
win/CS/HandBrakeWPF/ViewModels/CountdownAlertViewModel.cs
win/CS/HandBrakeWPF/ViewModels/EncoderOptionsViewModel.cs
win/CS/HandBrakeWPF/ViewModels/ErrorViewModel.cs
win/CS/HandBrakeWPF/ViewModels/OptionsViewModel.cs
win/CS/HandBrakeWPF/ViewModels/QueueViewModel.cs
win/CS/HandBrakeWPF/ViewModels/SubtitlesViewModel.cs
win/CS/HandBrakeWPF/ViewModels/VideoViewModel.cs
win/CS/HandBrakeWPF/Views/VideoView.xaml.cs
win/CS/HandBrakeWPF/Views/X264View.xaml.cs
win/CS/Settings.StyleCop

index 983af2e7ad8c22815d793591dce31cebd4d79722..c86bc5ff63f0c0c41ec2089b69d5505d2c122e97 100644 (file)
@@ -79,7 +79,6 @@ namespace HandBrake.ApplicationServices.Factories
                 preset.Task.MaxHeight = preset.Task.Width;\r
             }\r
 \r
-\r
             return preset;\r
         }\r
 \r
index a9969287327b2d8168def7c3968fc794b70bbb7b..ec805ab9d530a8003b37fda77c5333880f9165ef 100644 (file)
@@ -133,7 +133,6 @@ namespace HandBrake.ApplicationServices.Model
             this.FastDecode = task.FastDecode;\r
             this.ExtraAdvancedArguments = task.ExtraAdvancedArguments;\r
             \r
-\r
             this.PreviewStartAt = task.PreviewStartAt;\r
             this.PreviewDuration = task.PreviewDuration;\r
 \r
index ae0b66974c16f7449463fc53711a7b7b955f3a57..157be892029aaadbaa46e7477b2578cd99521569 100644 (file)
@@ -63,6 +63,9 @@ namespace HandBrake.ApplicationServices.Model.Encoding
         [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]\r
         private Audio scannedTrack;\r
 \r
+        /// <summary>\r
+        /// The is default.\r
+        /// </summary>\r
         private bool isDefault;\r
 \r
         #endregion\r
index 68f32011a56450523bd475c8de1624449b482b84..893ee69926f2df00c685d0e5257285e6fad86099 100644 (file)
@@ -76,12 +76,12 @@ namespace HandBrake.ApplicationServices.Model
         }\r
 \r
         /// <summary>\r
-        /// Gets the task.\r
+        /// Gets or sets the task.\r
         /// </summary>\r
         public EncodeTask Task { get; set; }\r
 \r
         /// <summary>\r
-        /// Gets the configuration.\r
+        /// Gets or sets the configuration.\r
         /// </summary>\r
         public HBConfiguration Configuration { get; set; }\r
 \r
index 720330c509cef01ae830f7dbc1bc3a92732d01f5..d5ee8655577cfb92d618f9d210253bea43e466af 100644 (file)
@@ -290,7 +290,7 @@ namespace HandBrake.ApplicationServices.Services.Base
 \r
                 return null;\r
             }\r
-            catch (Exception exc)\r
+            catch (Exception)\r
             {\r
                 return null;\r
             }\r
@@ -371,7 +371,7 @@ namespace HandBrake.ApplicationServices.Services.Base
                         }\r
                     }\r
                 }\r
-                catch (Exception exc)\r
+                catch (Exception)\r
                 {\r
                     // Do Nothing.\r
                 }\r
index 61bb1b57554596a8b580f963797a20a4baea50ad..42b066ee1c805454db9e04fb452fd81ff987165f 100644 (file)
@@ -258,7 +258,7 @@ namespace HandBrake.ApplicationServices.Services
                 this.HbProcess.CancelOutputRead();\r
                 this.ShutdownFileWriter();\r
             }\r
-            catch (Exception exc)\r
+            catch (Exception)\r
             {\r
                 // This exception doesn't warrent user interaction, but it should be logged (TODO)\r
             }\r
index 28754e15cca98c5bb55359ed1d44bdcfdbabda32..167394764997d8e63e60051a0ded2bf8646581d4 100644 (file)
@@ -98,7 +98,7 @@ namespace HandBrake.ApplicationServices.Services
                 HandBrakeUtils.MessageLogged += this.HandBrakeInstanceMessageLogged;\r
                 HandBrakeUtils.ErrorLogged += this.HandBrakeInstanceErrorLogged;\r
             }\r
-            catch (Exception exc)\r
+            catch (Exception)\r
             {\r
                 // Do nothing. \r
             }\r
@@ -178,7 +178,7 @@ namespace HandBrake.ApplicationServices.Services
                     this.scanLog.Dispose();\r
                     instance.Dispose();\r
                 }\r
-                catch (Exception exc)\r
+                catch (Exception)\r
                 {\r
                     // Do Nothing\r
                 }\r
index b0cfc9a74fdf3be2717d5c2d982a7c53f651c14f..7bc569ed7089d1c297c943852f03179c1bbb3206 100644 (file)
@@ -440,7 +440,7 @@ namespace HandBrake.ApplicationServices.Services
                     }\r
                 } \r
             }\r
-            catch (Exception exc)\r
+            catch (Exception)\r
             {\r
                 RecoverFromCorruptedPresetFile(this.builtInPresetFile);\r
                 this.UpdateBuiltInPresets();\r
index e7f4990bc3aed7fb710d1807ceeeeaf344a225d5..39dc864719cd2ed1fab73738728688d9e92b30ab 100644 (file)
@@ -87,7 +87,6 @@ namespace HandBrake.ApplicationServices.Services
             encodeService.ProcessLogs(destination, configuration);\r
         }\r
 \r
-\r
         /// <summary>\r
         /// Start the service\r
         /// </summary>\r
index 99c98c11641f0d3d952c1cb8fc85510e69278578..1cbff0cc99db6b5e4c24fce358976d46b6b77b97 100644 (file)
@@ -1,4 +1,7 @@
 <StyleCopSettings Version="105">\r
+  <GlobalSettings>\r
+    <BooleanProperty Name="AutoCheckForUpdate">False</BooleanProperty>\r
+  </GlobalSettings>\r
   <Analyzers>\r
     <Analyzer AnalyzerId="StyleCop.CSharp.DocumentationRules">\r
       <Rules>\r
index 371ef128fab61e282a4ac4a863c7ed3ddefd0511..78e8335c83a52f9867f96776743dd269bdf58ee1 100644 (file)
@@ -84,9 +84,8 @@ namespace HandBrake.ApplicationServices.Utilities
                 {\r
                     return val;\r
                 }\r
-\r
-                if (insensitiveCase && currDescription.ToLower() == description.ToLower() ||\r
-                    currDisplay.ToLower() == description.ToLower())\r
+                \r
+                if (insensitiveCase && currDescription.ToLower() == description.ToLower() || currDisplay.ToLower() == description.ToLower())\r
                 {\r
                     return val;\r
                 }\r
index 48212b519422152ccefd599e5ecfafb0e0754394..78320f1feeb79f2024aa8391ad746f28760e648c 100644 (file)
@@ -43,7 +43,6 @@ namespace HandBrake.ApplicationServices.Utilities
 \r
         #region Public Methods\r
 \r
-\r
         /// <summary>\r
         /// Load a plist file.\r
         /// </summary>\r
index 5552f19412a83daefcaa850a30de96c5b8f24f0b..b1db2fcaacdaaf618d778bbde3c536969074da34 100644 (file)
@@ -263,10 +263,12 @@ namespace HandBrake.ApplicationServices.Utilities
                 if (task.Height.HasValue && task.Height != 0) query += string.Format(" -l {0}", task.Height);\r
             }\r
 \r
-            //if (task.HasCropping)\r
-            //{\r
-            query += string.Format(" --crop {0}:{1}:{2}:{3}", task.Cropping.Top, task.Cropping.Bottom, task.Cropping.Left, task.Cropping.Right);\r
-            //}\r
+            query += string.Format(\r
+                " --crop {0}:{1}:{2}:{3}",\r
+                task.Cropping.Top,\r
+                task.Cropping.Bottom,\r
+                task.Cropping.Left,\r
+                task.Cropping.Right);\r
 \r
             switch (task.Anamorphic)\r
             {\r
@@ -442,7 +444,6 @@ namespace HandBrake.ApplicationServices.Utilities
                         query += string.Format(" -b {0}", task.VideoBitrate.Value);\r
                     break;\r
                 case VideoEncodeRateType.ConstantQuality:\r
-                    double value;\r
                     switch (task.VideoEncoder)\r
                     {\r
                         case VideoEncoder.FFMpeg:\r
index 30a473d9093d9e9700849c3a636b3acb4dab5945..5bfbb22d7b00e5ca4f7a83dd1843af71ef872018 100644 (file)
@@ -1,5 +1,5 @@
 // --------------------------------------------------------------------------------------------------------------------\r
-// <copyright file="OpenOptionsScreen.cs" company="HandBrake Project (http://handbrake.fr)">\r
+// <copyright file="OpenOptionsScreenCommand.cs" company="HandBrake Project (http://handbrake.fr)">\r
 //   This file is part of the HandBrake source code - It may be used under the terms of the GNU General Public License.\r
 // </copyright>\r
 // <summary>\r
index 905d8798a527121ca6465d83219b905c264cb142..1aeb7fdcbfe9247c0e72f27c8c48ec3b84cf664c 100644 (file)
@@ -40,7 +40,7 @@ namespace HandBrakeWPF.Converters
         /// The culture.\r
         /// </param>\r
         /// <returns>\r
-        /// The convert.\r
+        /// The Visibility Result\r
         /// </returns>\r
         public object Convert(object value, Type targetType, object parameter, CultureInfo culture)\r
         {\r
@@ -71,10 +71,9 @@ namespace HandBrakeWPF.Converters
         /// The culture.\r
         /// </param>\r
         /// <returns>\r
-        /// The convert back.\r
+        /// The Visibility Result\r
         /// </returns>\r
-        public object ConvertBack(\r
-            object value, Type targetType, object parameter, CultureInfo culture)\r
+        public object ConvertBack(object value, Type targetType, object parameter, CultureInfo culture)\r
         {\r
             Visibility visibility = (Visibility)value;\r
             bool result = visibility == Visibility.Visible;\r
index 1d3a4e2087b3239f5da4fdb889aee2989548c5ce..dd26399dba6560415b806ac1a84babdf3c4ebf74 100644 (file)
@@ -98,8 +98,6 @@ namespace HandBrakeWPF.Converters
                 return EnumHelper<VideoScaler>.GetEnumDisplayValues(typeof(VideoScaler));\r
             }\r
 \r
-\r
-\r
             // Single Items\r
             if (targetType == typeof(x264Preset) || value.GetType() == typeof(x264Preset))\r
             {\r
index 2911bb4fc631078bf4f8708b4681aa37692868b1..bd1e4c8d0ce57b6fbdf1533ba2ef025939544fa7 100644 (file)
@@ -7,7 +7,6 @@
 // </summary>\r
 // --------------------------------------------------------------------------------------------------------------------\r
 \r
-\r
 namespace HandBrakeWPF.Converters.Options\r
 {\r
     using System;\r
index 7cfceace3722e079a471517bd0725c4a874795d8..f6e4fc8006e6ad7a18d0d30669d215977b9a7a9f 100644 (file)
@@ -126,7 +126,6 @@ namespace HandBrakeWPF.Services
                 return;\r
             }\r
 \r
-\r
             if (this.userSettingService.GetUserSetting<string>(UserSettingConstants.WhenCompleteAction) == "Do nothing")\r
             {\r
                 return;\r
@@ -141,7 +140,6 @@ namespace HandBrakeWPF.Services
                         this.windowManager.ShowDialog(titleSpecificView);\r
                     });\r
 \r
-\r
             if (!titleSpecificView.IsCancelled)\r
             {\r
                 // Do something whent he encode ends.\r
index 6b7df3d8598230b11395e9ef16a2696b063196af..d10ec84df1eb264917413af44e4ef0ce105f6dc8 100644 (file)
@@ -216,7 +216,7 @@ namespace HandBrakeWPF.Services
                     return (SerializableDictionary<string, object>)this.serializer.Deserialize(stream);\r
                 }\r
             }\r
-            catch (Exception exc)\r
+            catch (Exception)\r
             {\r
                 return new SerializableDictionary<string, object>();\r
             }\r
index 296b1faa47c68e8ac74821055147fc1837642bdd..ed619b010d49863f8f1a0c24ba434aebb4ca28b0 100644 (file)
@@ -9,7 +9,6 @@
 \r
 namespace HandBrakeWPF.ViewModels\r
 {\r
-    using System;\r
     using System.Collections.Generic;\r
     using System.Collections.ObjectModel;\r
     using System.Collections.Specialized;\r
@@ -20,7 +19,6 @@ namespace HandBrakeWPF.ViewModels
     using HandBrake.ApplicationServices.Model;\r
     using HandBrake.ApplicationServices.Model.Encoding;\r
     using HandBrake.ApplicationServices.Parsing;\r
-    using HandBrake.ApplicationServices.Services.Interfaces;\r
     using HandBrake.ApplicationServices.Utilities;\r
     using HandBrake.Interop.Model.Encoding;\r
 \r
@@ -430,7 +428,6 @@ namespace HandBrakeWPF.ViewModels
         {\r
             List<Audio> trackList = new List<Audio>();\r
 \r
-\r
             List<string> isoCodes =\r
                 LanguageUtilities.GetLanguageCodes(\r
                     this.UserSettingService.GetUserSetting<StringCollection>(UserSettingConstants.SelectedLanguages));\r
index ca8901c7c618f63916a8f69498424993044b21ba..0f92c18b898ade496cf262b8362b32c19802fa7f 100644 (file)
@@ -10,7 +10,6 @@
 namespace HandBrakeWPF.ViewModels\r
 {\r
     using System;\r
-    using System.Windows.Forms.VisualStyles;\r
     using System.Windows.Threading;\r
 \r
     using HandBrakeWPF.ViewModels.Interfaces;\r
index f7968fcb40d06c3bb76298bfeb37875428742c57..42407aadf3b54e2ef52fc45d34aef2a535d4ed20 100644 (file)
@@ -20,7 +20,7 @@ namespace HandBrakeWPF.ViewModels
     /// <summary>\r
     /// The Simple Encoder options screen\r
     /// </summary>\r
-    public class EncoderOptionsViewModel : ViewModelBase, IEncoderOptionsViewModel, ITabInterface\r
+    public class EncoderOptionsViewModel : ViewModelBase, IEncoderOptionsViewModel\r
     {\r
         /// <summary>\r
         /// The cached options.\r
@@ -30,12 +30,12 @@ namespace HandBrakeWPF.ViewModels
         /// <summary>\r
         /// Initializes a new instance of the <see cref="EncoderOptionsViewModel"/> class.\r
         /// </summary>\r
-        public EncoderOptionsViewModel()
-        {
-            this.Task = new EncodeTask();
-        }
-
-        /// <summary>
+        public EncoderOptionsViewModel()\r
+        {\r
+            this.Task = new EncodeTask();\r
+        }\r
+\r
+        /// <summary>\r
         /// Gets or sets the task.\r
         /// </summary>\r
         public EncodeTask Task { get; set; }\r
index e6bbfe6d424c487805becc6ff240f7d3bc3f4c3a..78e4867eaca190c0af2f3ab169487b9f1319972d 100644 (file)
@@ -120,7 +120,6 @@ namespace HandBrakeWPF.ViewModels
             {\r
                 Console.WriteLine(e);\r
             }\r
-\r
         }\r
 \r
         /// <summary>\r
index f8a86494ed678d82320df72a9cdfeaac03774261..dde54a5c6dabf22e76bb5992ee016145234694d1 100644 (file)
@@ -2039,7 +2039,6 @@ namespace HandBrakeWPF.ViewModels
             this.userSettingService.SetUserSetting(UserSettingConstants.EnableDxva, this.EnableDxvaDecoding);\r
             this.userSettingService.SetUserSetting(UserSettingConstants.ScalingMode, this.SelectedScalingMode);\r
 \r
-\r
             /* System and Logging */\r
             userSettingService.SetUserSetting(UserSettingConstants.ProcessPriority, this.SelectedPriority);\r
             userSettingService.SetUserSetting(UserSettingConstants.PreventSleep, this.PreventSleep);\r
index e89ecc4cd3d0a77c3e0210c4079000b854ad4244..3347cfddd469abc7a22c9f0b3cdca8a4867b4e86 100644 (file)
@@ -415,13 +415,10 @@ namespace HandBrakeWPF.ViewModels
         /// <param name="e">\r
         /// The EncodeProgressEventArgs.\r
         /// </param>\r
-        private void EncodeService_EncodeStatusChanged(\r
-            object sender, EncodeProgressEventArgs e)\r
+        private void EncodeService_EncodeStatusChanged(object sender, EncodeProgressEventArgs e)\r
         {\r
             Caliburn.Micro.Execute.OnUIThread(() =>\r
             {\r
-\r
-\r
                 this.JobStatus =\r
                     string.Format(\r
                         "Encoding: Pass {0} of {1},  {2:00.00}%, FPS: {3:000.0},  Avg FPS: {4:000.0},  Time Remaining: {5},  Elapsed: {6:hh\\:mm\\:ss}",\r
index 4a28438b73d14e4ebbb61e441763d1a9c19efe23..467535bc3ab578da661e34191364d6e2f01ba02f 100644 (file)
@@ -13,7 +13,6 @@ namespace HandBrakeWPF.ViewModels
     using System.Collections.Specialized;\r
     using System.IO;\r
     using System.Linq;\r
-    using System.Windows.Controls.Primitives;\r
 \r
     using HandBrake.ApplicationServices.Model;\r
     using HandBrake.ApplicationServices.Model.Encoding;\r
@@ -34,14 +33,14 @@ namespace HandBrakeWPF.ViewModels
         #region Constants and Fields\r
 \r
         /// <summary>\r
-        /// Backing field for the source subtitle tracks.\r
+        /// The Foreign Audio Search Track\r
         /// </summary>\r
-        private IList<Subtitle> sourceTracks;\r
+        private readonly Subtitle ForeignAudioSearchTrack;\r
 \r
         /// <summary>\r
-        /// The Foreign Audio Search Track\r
+        /// Backing field for the source subtitle tracks.\r
         /// </summary>\r
-        private readonly Subtitle ForeignAudioSearchTrack;\r
+        private IList<Subtitle> sourceTracks;\r
 \r
         #endregion\r
 \r
index d12798fef39c632f4ba064e441b23413a6a047c6..5dd4b07aab4079e040391951f1eed3b80f5dfc25 100644 (file)
@@ -14,7 +14,6 @@ namespace HandBrakeWPF.ViewModels
     using System.ComponentModel;\r
     using System.Globalization;\r
     using System.Linq;\r
-    using System.ServiceModel.Channels;\r
     using System.Windows;\r
 \r
     using Caliburn.Micro;\r
@@ -22,7 +21,6 @@ namespace HandBrakeWPF.ViewModels
     using HandBrake.ApplicationServices.Model;\r
     using HandBrake.ApplicationServices.Model.Encoding;\r
     using HandBrake.ApplicationServices.Parsing;\r
-    using HandBrake.ApplicationServices.Services.Interfaces;\r
     using HandBrake.ApplicationServices.Utilities;\r
     using HandBrake.Interop;\r
     using HandBrake.Interop.Model.Encoding;\r
@@ -477,7 +475,6 @@ namespace HandBrakeWPF.ViewModels
             }\r
         }\r
 \r
-\r
         /// <summary>\r
         /// Gets or sets SelectedFramerate.\r
         /// </summary>\r
@@ -619,7 +616,6 @@ namespace HandBrakeWPF.ViewModels
             }\r
         }\r
 \r
-\r
         /// <summary>\r
         /// Gets or sets a value indicating whether display x 264 options.\r
         /// </summary>\r
@@ -637,7 +633,6 @@ namespace HandBrakeWPF.ViewModels
             }\r
         }\r
 \r
-\r
         /// <summary>\r
         /// Gets or sets a value indicating whether to display qsv options.\r
         /// </summary>\r
@@ -847,7 +842,6 @@ namespace HandBrakeWPF.ViewModels
         /// </summary>\r
         public BindingList<QsvPreset> QsvPresets { get; set; }\r
 \r
-\r
         /// <summary>\r
         /// Gets or sets X264Profiles.\r
         /// </summary>\r
index e9d54d4ce59ebf804d15571b0081aff92a24145c..9f12972beac6702fb9db1f680e59bff5bbd548c5 100644 (file)
@@ -13,14 +13,9 @@ namespace HandBrakeWPF.Views
     using System.Windows;\r
     using System.Windows.Controls;\r
 \r
-    using Caliburn.Micro;\r
-\r
     using HandBrake.ApplicationServices.Model;\r
-    using HandBrake.ApplicationServices.Utilities;\r
-    using HandBrake.Interop.Model.Encoding;\r
 \r
     using HandBrakeWPF.ViewModels;\r
-    using HandBrakeWPF.ViewModels.Interfaces;\r
 \r
     /// <summary>\r
     /// Interaction logic for VideoView.xaml\r
@@ -35,22 +30,39 @@ namespace HandBrakeWPF.Views
             InitializeComponent();\r
         }\r
 \r
-\r
+        /// <summary>\r
+        /// The qsv_preset_radiobutton.\r
+        /// </summary>\r
+        /// <param name="sender">\r
+        /// The sender.\r
+        /// </param>\r
+        /// <param name="e">\r
+        /// The e.\r
+        /// </param>\r
         private void qsv_preset_radiobutton(object sender, System.Windows.RoutedEventArgs e)\r
         {\r
             qsv_preset_ValueChanged(sender, null);\r
         }\r
 \r
+        /// <summary>\r
+        /// The qsv_preset_ value changed.\r
+        /// </summary>\r
+        /// <param name="sender">\r
+        /// The sender.\r
+        /// </param>\r
+        /// <param name="e">\r
+        /// The e.\r
+        /// </param>\r
         private void qsv_preset_ValueChanged(object sender, RoutedPropertyChangedEventArgs<double> e)\r
         {\r
-            VideoViewModel mvm = ((VideoViewModel)this.DataContext);
-            EncodeTask task = mvm.Task;
-
-            string full_string = "";
-
-            IDictionary<string, string> newOptions = new Dictionary<string, string>();
-            string[] existingSegments = full_string.Split(':');
-            foreach (string existingSegment in existingSegments)
+            VideoViewModel mvm = ((VideoViewModel)this.DataContext);\r
+            EncodeTask task = mvm.Task;\r
+\r
+            string full_string = string.Empty;\r
+\r
+            IDictionary<string, string> newOptions = new Dictionary<string, string>();\r
+            string[] existingSegments = full_string.Split(':');\r
+            foreach (string existingSegment in existingSegments)\r
             {\r
                 string optionName = existingSegment;\r
                 string optionValue = string.Empty;\r
@@ -70,7 +82,7 @@ namespace HandBrakeWPF.Views
                 }\r
             }\r
 \r
-            full_string = "";\r
+            full_string = string.Empty;\r
             foreach (KeyValuePair<string, string> entry in newOptions)\r
             {\r
                 full_string += entry.Key;\r
index 7c7f9bea3984239529b6b8ce5d3e632c037f3a01..42764bf5c7aa37cbdfd2b582797dae56379dc325 100644 (file)
@@ -1,23 +1,21 @@
 // --------------------------------------------------------------------------------------------------------------------\r
-// <copyright file="AdvancedView.xaml.cs" company="HandBrake Project (http://handbrake.fr)">\r
+// <copyright file="X264View.xaml.cs" company="HandBrake Project (http://handbrake.fr)">\r
 //   This file is part of the HandBrake source code - It may be used under the terms of the GNU General Public License.\r
 // </copyright>\r
 // <summary>\r
-//   Interaction logic for AdvancedView.xaml\r
+//   Interaction logic for X264View.xaml\r
 // </summary>\r
 // --------------------------------------------------------------------------------------------------------------------\r
 \r
 namespace HandBrakeWPF.Views\r
 {\r
-    using System.Windows.Controls;\r
-\r
     /// <summary>\r
     /// Interaction logic for AdvancedView.xaml\r
     /// </summary>\r
-    public partial class X264View : UserControl\r
+    public partial class X264View\r
     {\r
         /// <summary>\r
-        /// Initializes a new instance of the <see cref="AdvancedView"/> class.\r
+        /// Initializes a new instance of the <see cref="X264View"/> class. \r
         /// </summary>\r
         public X264View()\r
         {\r
index 9ce4e6158593a4c9d591b7975b954b0eb723e6c9..7b02bc0d525139c3b7724a3cf38a7b01a3b6dfbf 100644 (file)
             <BooleanProperty Name="Enabled">False</BooleanProperty>\r
           </RuleSettings>\r
         </Rule>\r
+        <Rule Name="PrefixCallsCorrectly">\r
+          <RuleSettings>\r
+            <BooleanProperty Name="Enabled">False</BooleanProperty>\r
+          </RuleSettings>\r
+        </Rule>\r
       </Rules>\r
       <AnalyzerSettings />\r
     </Analyzer>\r