]> granicus.if.org Git - python/commitdiff
asyncio doc: use server.wait_closed() in TCP echo server example
authorVictor Stinner <victor.stinner@gmail.com>
Sun, 12 Oct 2014 09:13:40 +0000 (11:13 +0200)
committerVictor Stinner <victor.stinner@gmail.com>
Sun, 12 Oct 2014 09:13:40 +0000 (11:13 +0200)
Doc/library/asyncio-protocol.rst

index 52da1b41ddea8007460ebb7eea531f2f2bc78df6..ec6a479f1cd63e71b2c40421add64a509da54bfa 100644 (file)
@@ -473,6 +473,7 @@ having to write a short coroutine to handle the exception and stop the
 running loop. At :meth:`~BaseEventLoop.run_until_complete` exit, the loop is
 no longer running, so there is no need to stop the loop in case of an error.
 
+
 TCP echo server
 ---------------
 
@@ -483,28 +484,34 @@ TCP echo server example, send back received data and close the connection::
     class EchoServer(asyncio.Protocol):
         def connection_made(self, transport):
             peername = transport.get_extra_info('peername')
-            print('connection from {}'.format(peername))
+            print('Connection from {}'.format(peername))
             self.transport = transport
 
         def data_received(self, data):
-            print('data received: {}'.format(data.decode()))
+            message = data.decode()
+            print('Data received: {!r}'.format(message))
+
+            print('Send: {!r}'.format(message))
             self.transport.write(data)
 
-            # close the socket
+            print('Close the socket')
             self.transport.close()
 
     loop = asyncio.get_event_loop()
     coro = loop.create_server(EchoServer, '127.0.0.1', 8888)
     server = loop.run_until_complete(coro)
-    print('serving on {}'.format(server.sockets[0].getsockname()))
 
+    # Server requests until CTRL+c is pressed
+    print('Serving on {}'.format(server.sockets[0].getsockname()))
     try:
         loop.run_forever()
     except KeyboardInterrupt:
         print("exit")
-    finally:
-        server.close()
-        loop.close()
+
+    # Close the server
+    server.close()
+    loop.run_until_complete(server.wait_closed())
+    loop.close()
 
 :meth:`Transport.close` can be called immediately after
 :meth:`WriteTransport.write` even if data are not sent yet on the socket: both