]> granicus.if.org Git - postgresql/commitdiff
Fix bug slowing down pgbench when -P is used.
authorAndres Freund <andres@anarazel.de>
Fri, 7 Aug 2015 23:19:02 +0000 (01:19 +0200)
committerAndres Freund <andres@anarazel.de>
Fri, 7 Aug 2015 23:19:02 +0000 (01:19 +0200)
A removed check in ba3deeefb made all threads but the main one busy-loop
when -P was used. All threads computed the time to the next time the
progress report should be printed, but only the main thread did so and
re-scheduled it only for the future.

Reported-By: Jesper Pedersen
Discussion: 55C4E190.3050104@redhat.com

src/bin/pgbench/pgbench.c

index 30a59afcce5df9398ebff31129ccb83bd5c97992..6f5bd994a09df8922bcbf3b45d9bb3c34eba426d 100644 (file)
@@ -3646,7 +3646,7 @@ threadRun(void *arg)
                }
 
                /* also wake up to print the next progress report on time */
-               if (progress && min_usec > 0)
+               if (progress && min_usec > 0 && thread->tid == 0)
                {
                        /* get current time if needed */
                        if (now_usec == 0)