Solved a potential deadlock in test_telnetlib.py. Related to issue #11812

diff --git a/Lib/test/test_telnetlib.py b/Lib/test/test_telnetlib.py
index a78b938b86fb00bfe31da27b42b07acb51df971a..0f0b2ac82d79821fbbe70642f5db8627958fc5fe 100644 (file)
--- a/Lib/test/test_telnetlib.py
+++ b/Lib/test/test_telnetlib.py
@@ -21,7 +21,6 @@ def server(evt, serv):
         conn.close()
     finally:
         serv.close()
-        evt.set()
 
 class GeneralTests(TestCase):
 
@@ -33,11 +32,8 @@ class GeneralTests(TestCase):
         self.thread = threading.Thread(target=server, args=(self.evt,self.sock))
         self.thread.start()
         self.evt.wait()
-        self.evt.clear()
-        time.sleep(.1)
 
     def tearDown(self):
-        self.evt.wait()
         self.thread.join()
 
     def testBasic(self):

diff --git a/Misc/NEWS b/Misc/NEWS
index 0d5f98116d84067c60f6f585ff70e8f03be2ff8e..5529786d8026edd197be794c512e6d3354846f86 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -527,6 +527,8 @@ Tests
 - Skip network tests when getaddrinfo() returns EAI_AGAIN, meaning a temporary
   failure in name resolution.
 
+- Solved a potential deadlock in test_telnetlib.py. Related to issue #11812.
+
 - Avoid failing in test_urllibnet.test_bad_address when some overzealous
   DNS service (e.g. OpenDNS) resolves a non-existent domain name.  The test
   is now skipped instead.