]> granicus.if.org Git - apache/commitdiff
The default timeout value of 10s lives in two places, the per-server config
authorEric Covener <covener@apache.org>
Thu, 8 Sep 2011 12:53:06 +0000 (12:53 +0000)
committerEric Covener <covener@apache.org>
Thu, 8 Sep 2011 12:53:06 +0000 (12:53 +0000)
and in this initialization. Drop the latter and check to see if a timeout
is requested in the per-server config.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1166662 13f79535-47bb-0310-9956-ffa450edef68

modules/ldap/util_ldap.c

index c7d017bbde46578c2ece06b23a769dc036605e46..075e9d8c870519baa7e2dd91357fa3d4e31fa71e 100644 (file)
@@ -257,7 +257,7 @@ static int uldap_connection_init(request_rec *r,
     int version  = LDAP_VERSION3;
     apr_ldap_err_t *result = NULL;
 #ifdef LDAP_OPT_NETWORK_TIMEOUT
-    struct timeval connectionTimeout = {10,0};    /* 10 second connection timeout */
+    struct timeval connectionTimeout = {0}; 
 #endif
     util_ldap_state_t *st =
         (util_ldap_state_t *)ap_get_module_config(r->server->module_config,
@@ -417,7 +417,7 @@ static int uldap_connection_init(request_rec *r,
         connectionTimeout.tv_sec = st->connectionTimeout;
     }
 
-    if (st->connectionTimeout >= 0) {
+    if (connectionTimeout.tv_sec > 0) {
         rc = apr_ldap_set_option(r->pool, ldc->ldap, LDAP_OPT_NETWORK_TIMEOUT,
                                  (void *)&connectionTimeout, &(result));
         if (APR_SUCCESS != rc) {