Fix a loop overrun in ComputePreamble when the last remapped file was erased,

and reenable crash recovery test.
 - Reparsing is still very crashy / weird, so I had to sprinkle random code into
   the remapped input to get it to do what I want (i.e., crash!).

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@111550 91177308-0d34-0410-b5e6-96231b3b80d8

diff --git a/lib/Frontend/ASTUnit.cpp b/lib/Frontend/ASTUnit.cpp
index 523b8d0a6c2165f47459ff6c03548829d7874791..4395246f49324c213ed9222803cf00e11056d18a 100644 (file)
--- a/lib/Frontend/ASTUnit.cpp
+++ b/lib/Frontend/ASTUnit.cpp
@@ -850,6 +850,8 @@ ASTUnit::ComputePreamble(CompilerInvocation &Invocation,
           // Remove this remapping. We've captured the buffer already.
           M = PreprocessorOpts.eraseRemappedFile(M);
           E = PreprocessorOpts.remapped_file_end();
+          if (M == E)
+            break;
         }
       }
     }
@@ -875,6 +877,8 @@ ASTUnit::ComputePreamble(CompilerInvocation &Invocation,
           // Remove this remapping. We've captured the buffer already.
           M = PreprocessorOpts.eraseRemappedFile(M);
           E = PreprocessorOpts.remapped_file_buffer_end();
+          if (M == E)
+            break;
         }
       }
     }

diff --git a/test/Index/Inputs/crash-recovery-reparse-remap.c b/test/Index/Inputs/crash-recovery-reparse-remap.c
index 8a7707a59024314a15a4f5bb12b902fa1e32e771..0357dbe748a8baf1ab98728c14805fd86811c527 100644 (file)
--- a/test/Index/Inputs/crash-recovery-reparse-remap.c
+++ b/test/Index/Inputs/crash-recovery-reparse-remap.c
@@ -1,3 +1,11 @@
+
 #warning parsing remapped file
 
+
+
+int x;
+
 #pragma clang __debug crash
+
+int x;
+

diff --git a/test/Index/crash-recovery-reparse.c b/test/Index/crash-recovery-reparse.c
index 90ce25d1ad2bee1e3545e6d397c9b67bd3c191f3..0697576880f7a17137f4b2eb9de8af967513a551 100644 (file)
--- a/test/Index/crash-recovery-reparse.c
+++ b/test/Index/crash-recovery-reparse.c
@@ -1,12 +1,8 @@
-// Disabled, pending investigation.
-// RUN: false
-// XFAIL: *
-//
-// RUNX: env CINDEXTEST_EDITING=1 \
-// RUNX:   not c-index-test -test-load-source-reparse 1 local \
-// RUNX:   -remap-file="%s;%S/Inputs/crash-recovery-reparse-remap.c" \
-// RUNX:   %s 2> %t.err
-// RUNX: FileCheck < %t.err -check-prefix=CHECK-REPARSE-SOURCE-CRASH %s
+// RUN: env CINDEXTEST_EDITING=1 \
+// RUN:   not c-index-test -test-load-source-reparse 1 local \
+// RUN:   -remap-file="%s;%S/Inputs/crash-recovery-reparse-remap.c" \
+// RUN:   %s 2> %t.err
+// RUN: FileCheck < %t.err -check-prefix=CHECK-REPARSE-SOURCE-CRASH %s
 // CHECK-REPARSE-SOURCE-CRASH: Unable to reparse translation unit
 //
 // XFAIL: win32