]> granicus.if.org Git - clang/commitdiff
Walk out of enums when determining effective context.
authorJohn McCall <rjmccall@apple.com>
Wed, 24 Mar 2010 09:04:37 +0000 (09:04 +0000)
committerJohn McCall <rjmccall@apple.com>
Wed, 24 Mar 2010 09:04:37 +0000 (09:04 +0000)
git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@99391 91177308-0d34-0410-b5e6-96231b3b80d8

lib/Sema/SemaAccess.cpp
test/CXX/class.access/p4.cpp

index 5b1a9d880a910f4715a025f9e25dd89b559c1886..7e2520c9eeeb152538186d8513a5d4b613f8dafe 100644 (file)
@@ -59,6 +59,9 @@ struct EffectiveContext {
     : Inner(DC),
       Dependent(DC->isDependentContext()) {
 
+    if (isa<EnumDecl>(DC))
+      DC = cast<EnumDecl>(DC)->getDeclContext();
+
     if (isa<FunctionDecl>(DC)) {
       Function = cast<FunctionDecl>(DC)->getCanonicalDecl();
       DC = Function->getDeclContext();
@@ -103,7 +106,14 @@ struct EffectiveContext {
 }
 
 static CXXRecordDecl *FindDeclaringClass(NamedDecl *D) {
-  CXXRecordDecl *DeclaringClass = cast<CXXRecordDecl>(D->getDeclContext());
+  DeclContext *DC = D->getDeclContext();
+
+  // This can only happen at top: enum decls only "publish" their
+  // immediate members.
+  if (isa<EnumDecl>(DC))
+    DC = cast<EnumDecl>(DC)->getDeclContext();
+
+  CXXRecordDecl *DeclaringClass = cast<CXXRecordDecl>(DC);
   while (DeclaringClass->isAnonymousStructOrUnion())
     DeclaringClass = cast<CXXRecordDecl>(DeclaringClass->getDeclContext());
   return DeclaringClass;
index bc69bee657c97aacdd882eee37899365c7f09339..0c87c07e06405a3bee300ab2480057c25288c349 100644 (file)
@@ -262,3 +262,24 @@ namespace test9 {
     static int getX() { return x; } // expected-error {{'x' is a private member of 'test9::A'}}
   };
 }
+
+namespace test10 {
+  class A {
+    enum {
+      value = 10 // expected-note {{declared private here}}
+    };
+    friend class C;
+  };
+
+  class B {
+    enum {
+      value = A::value // expected-error {{'value' is a private member of 'test10::A'}}
+    };
+  };
+
+  class C {
+    enum {
+      value = A::value
+    };
+  };
+}