]> granicus.if.org Git - cgit/commitdiff
ui-blame: add a link to the parent commit in blame
authorJohn Keeping <john@keeping.me.uk>
Sun, 13 Feb 2022 15:29:06 +0000 (15:29 +0000)
committerJason A. Donenfeld <Jason@zx2c4.com>
Mon, 19 Dec 2022 15:13:58 +0000 (16:13 +0100)
When walking through the history, it is useful to quickly see the same
file at the previous revision, so add a link to do this.

It would be nice to link to the correct line with an additional
fragment, but this requires significantly more work so it can be done as
an enhancement later.  (ent->s_lno is mostly the right thing, but it is
the line number in the post-image of the target commit whereas the link
is to the parent of that commit, i.e. the pre-image of the target.)

Suggested-by: Alejandro Colomar <alx.manpages@gmail.com>
Signed-off-by: John Keeping <john@keeping.me.uk>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
ui-blame.c

index 4adec2b99e5f19af19109f92677def0e635e5e9a..aedce8dfd24aa0b4db686360120bdd04b0a0cd5f 100644 (file)
@@ -54,6 +54,15 @@ static void emit_blame_entry_hash(struct blame_entry *ent)
        html("</span>");
        free(detail);
 
+       if (!parse_commit(suspect->commit) && suspect->commit->parents) {
+               struct commit *parent = suspect->commit->parents->item;
+
+               html(" ");
+               cgit_blame_link("^", "Blame the previous revision", NULL,
+                               ctx.qry.head, oid_to_hex(&parent->object.oid),
+                               suspect->path);
+       }
+
        while (line++ < ent->num_lines)
                html("\n");
 }