]> granicus.if.org Git - linux-pam/commitdiff
pam_loginuid: cleanup loginuid buffer initialization
authorDmitry V. Levin <ldv@altlinux.org>
Sun, 19 Jan 2014 14:02:53 +0000 (14:02 +0000)
committerDmitry V. Levin <ldv@altlinux.org>
Wed, 22 Jan 2014 22:55:25 +0000 (22:55 +0000)
* modules/pam_loginuid/pam_loginuid.c (set_loginuid): Move loginuid
buffer initialization closer to its first use.

modules/pam_loginuid/pam_loginuid.c

index d25842289687feba56f15b87c814125664a89707..c476f7b6b89a4db2cfbea5252133854c31c59808 100644 (file)
@@ -69,7 +69,6 @@ static int set_loginuid(pam_handle_t *pamh, uid_t uid)
                close(fd);
        }
 
-       count = snprintf(loginuid, sizeof(loginuid), "%lu", (unsigned long)uid);
        fd = open("/proc/self/loginuid", O_NOFOLLOW|O_RDWR);
        if (fd < 0) {
                if (errno == ENOENT) {
@@ -82,6 +81,7 @@ static int set_loginuid(pam_handle_t *pamh, uid_t uid)
                return rc;
        }
 
+       count = snprintf(loginuid, sizeof(loginuid), "%lu", (unsigned long)uid);
        if (pam_modutil_read(fd, buf, sizeof(buf)) == count &&
            memcmp(buf, loginuid, count) == 0) {
                rc = PAM_SUCCESS;